Opened 13 years ago

Closed 13 years ago

#187 closed defect (fixed)

Non-matching file list doesn't work in GUI mode mondorestore compare.

Reported by: Scott Cummings Owned by: Bruno Cornec
Priority: normal Milestone: 2.2.5
Component: mondo Version: 2.2.4
Severity: normal Keywords:
Cc:

Description

Before Non-matching file list is displayed the code checks to see if the file exists. Most files are found to not exist, since the filenames are relative and the current directory is /, not /mnt/RESTORING. Also the disks are unmounted before the check.

This can be fixed by either removing the existence check or applying the attached patch.

Attachments (2)

diff_libmondo-string.c (147 bytes) - added by Scott Cummings 13 years ago.
diff_mondo-rstr-compare.c (2.4 KB) - added by Scott Cummings 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Scott Cummings

Attachment: diff_libmondo-string.c added

comment:1 Changed 13 years ago by Scott Cummings

test for existence is in:

common/newt-specific.c
 load_filelist_into_array
   if (!does_file_exist(tmp)) {
      goto god_i_hate_gotos;

Called from:

popup_changelist_from_file 

comment:2 Changed 13 years ago by Scott Cummings

In diff_libmondo-string.c, maybe it should say "in home directory" instead of partition, since it may not be in its own partition.

Changed 13 years ago by Scott Cummings

Attachment: diff_mondo-rstr-compare.c added

comment:3 Changed 13 years ago by Bruno Cornec

Resolution: fixed
Status: newclosed

Fixed in rev 1585.

Thanks a lot for your patch.

Note: See TracTickets for help on using tickets.