output from fdisk -l stderr when starting mondoarchive on an ubuntu 12.04 system with lvm

[Joel Kociolek]

Hi,

Patch attached.

System: Ubuntu 12.04.

Server using LVM.

Versions used are the most recent prepackaged provided for Ubuntu 12.04 i386 :

• mondo 3.0.2-1
• mindi 2.1.2-1
• mindi-busybox 1.18.5-2

When I start mondoarchive by hand and immediately exit thereafter I get this output:

Initializing...
See /var/log/mondoarchive.log for details of backup run.
Checking sanity of your Linux distribution
Disk /dev/mapper/vg0-home doesn't contain a valid partition table
Disk /dev/mapper/vg0-tmp doesn't contain a valid partition table
Disk /dev/mapper/vg0-var doesn't contain a valid partition table
Done.
Execution run ended; result=1
Type 'less /var/log/mondoarchive.log' to see the output log

The lines ending with "doesn't contain a vlid partition table" shouldn't (obviously) be there. They come from stderr of "fdisk -l".

I corrected the problem by redirecting stderr of fdisk -l to /dev/null in line 1018 of src/common/libmondo-tools.c (see attached patch)

For a bit more of discussion: actually I get the same output from cron nightly backups, but this way to demonstrate it seemed simpler. Also, it seems that older versions of fdisk used to skip lvm volumes when doing an fdisk -l, but not the version in ubuntu 12.04.

And by the way: thanks for mondoarchive!

[Joel Kociolek]

Patch correcting the bug

[Bruno Cornec]

Thanks for your patch. Applied in rev [3054]