bug in mindi rcS file concerning OBDR detection

[vicgat]

It seems that there is a bug in mindi 3.0.1 rootfs/etc/init.d/rcS concerning OBDR detection.

rcS executes :

hpsa_obdr_mode -m query /dev/cciss/* 2>&1 | grep "is an OBDR device"

but that hpsa_obdr_mode command returns nothing, it needs "-v" to return the information.

So it has to be :

hpsa_obdr_mode -v -m query /dev/cciss/* 2>&1 | grep "is an OBDR device"

[vicgat]

Sorry, it's not mindi 3.0.1, it's mindi 2.1.0 ;-)

[vicgat]

Probably the same problem for

/usr/bin/hpsa_obdr_mode -m query -l $lun /dev/cciss/* 2>&1 | grep -q "is in CD-ROM mode"

which should be

/usr/bin/hpsa_obdr_mode -v -m query -l $lun /dev/cciss/* 2>&1 | grep -q "is in CD-ROM mode"

I cannot test all that, because we sent our DAT drive to you...you'll be able to test it with the DAT drive.

Rgds.

[vicgat]

Example, on our test server cq56 (DL360 with Smart Array E200i) with hpsa_obdr_mode-1.03

# /usr/bin/hpsa_obdr_mode -m query /dev/sg*  
#

# /usr/bin/hpsa_obdr_mode -v -m query /dev/sg*
/dev/sg0:
Not a smart array

[vicgat]

Sorry again, in mindi 2.1.0 and 2.1.1 rootfs/etc/init.d/rcS it's not sg, it's cciss (I used sg too for my tests).

So, in mindi 2.1.1 rootfs/etc/init.d/rcS file :

Line 659: /usr/bin/hpsa_obdr_mode -m query /dev/cciss/*
Line 660: /usr/bin/hpsa_obdr_mode -m query -l $lun /dev/cciss/*

should be modified as following

/usr/bin/hpsa_obdr_mode -v -m query /dev/cciss/*
/usr/bin/hpsa_obdr_mode -v -m query -l $lun /dev/cciss/*

[vicgat]

Example

# /usr/bin/hpsa_obdr_mode -m query /dev/cciss/*  
#

# /usr/bin/hpsa_obdr_mode -v -m query /dev/cciss/*  
/dev/cciss/c0d0:
Device is not a RAID controller device
/dev/cciss/c0d0p1:
Device is not a RAID controller device
...

[vicgat]

mindi 2.1.0 and 2.1.1 rcS file (/usr/lib64/mindi/rootfs/etc/init.d/rcS)

[bruno]

in hpsa_obdr_mode.c line 369 you have:

if ((debug) || (mode == QUERY))

so indeed using -v prints the message but using the query mode (-m query as well) so IF you have an OBDR device a message will be printed even without -v. And else nothing will be printed.