Opened 10 years ago

Closed 10 years ago

#375 closed defect (fixed)

mondoarchive / mondorestore will segfault if the partition decidied by sensibly_set_tmpdir_and_scratchdir() is read-only

Reported by: cylau Owned by: bruno
Priority: highest Milestone: 2.2.9.2
Component: mondo Version: 2.2.9.1
Severity: blocker Keywords:
Cc:

Description

mondo version = mondo-2.2.9.1 In src/common/libmondo-devices.c (Line 2772) In void sensibly_set_tmpdir_and_scratchdir() :

The output of call_program_and_get_last_line_of_output

LANGUAGE=C df -m -P -x nfs -x nfs4 -x fuse.sshfs -x fuse -x vfat -x ntfs -x ntfs-3g -x smbfs -x smb -x cifs -x afs -x gfs -x ocfs -x ocfs2 -x mvfs -x nsspool -x nssvol -x iso9660 | grep -vE "none|Filesystem|/dev/shm" | awk '{printf "%s %s\n", $4, $6;}' | sort -nr | awk '{print $NF;}'

This command line does not avoid the partition which is mounted as read only, and it will make segfault in later lines.

For example, If /local is the largest partition with most available spaces, but it is mounted as read only, it cannot create the scratch.

Attached the proposed patch file and spec file for RHEL5:

Attachments (2)

mondo-skip-ro-filesystem.patch (1.8 KB) - added by cylau 10 years ago.
mondo-patched.spec (85.4 KB) - added by cylau 10 years ago.
rpm spec file for RHEL5

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by cylau

Changed 10 years ago by cylau

rpm spec file for RHEL5

comment:1 Changed 10 years ago by cylau

  • Severity changed from critical to blocker

comment:2 Changed 10 years ago by bruno

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for your patch. Applied for 2.2.9.2 in rev [2501]

Note: See TracTickets for help on using tickets.