Opened 8 years ago

Closed 4 years ago

#805 closed enhancement (fixed)

mr-parted2fdisk should use parted when there's a lot of disks

Reported by: victor gattegno Owned by: Bruno Cornec
Priority: high Milestone: 3.3.0
Component: mindi Version: 3.2.2
Severity: critical Keywords: mr-parted2fdisk fdisk parted
Cc: victor_gattegno@…

Description

When there's a lot of disks, some fdisk fail to list it all, and then, may not list the boot device.

In that case, boot device will not be found by mr-parted2fdisk because it's using fdisk (and parted only in some issues).

So the solution in this case (a lot of disks to scan) is to use parted instead of fdisk in mr-parted2fdisk.

Change History (7)

comment:1 by victor gattegno, 8 years ago

A solution in mr-parted2fdisk program could be to check if boot partition is listed in the result of 'fdisk -l', and, if not, to check it through parted.

That would workaround any fdisk bug (example : https://access.redhat.com/solutions/783403 bug, fixed in util-linux-ng-2.17.2-12.24).

comment:2 by Bruno Cornec, 7 years ago

Status: newassigned

Should be fixed with rev [3647]

Victor could you check by just using that version of mr-parted2fdisk with th existing mindi setup (replacing it should be all you need to do) and report back.

Thanks !

comment:3 by Bruno Cornec, 7 years ago

Resolution: fixed
Status: assignedclosed

Closing for now. Please reopen if needed.

comment:4 by victor gattegno, 7 years ago

Resolution: fixed
Status: closedreopened

comment:5 by victor gattegno, 7 years ago

mr-parted2fdisk [rev 3647 http://trac.mondorescue.org/changeset/3647] was tested on a lot of disks with the "1000" limit, and also with the limit set to "30" :

$use_parted = 1 if ($lines >= 30)

But it still doesn't detect the boot partition.

I emailed to Bruno the result.

comment:6 by Bruno Cornec, 7 years ago

This should be finally much improved with rev [3666]. Please check again and report back your findings !

comment:7 by Bruno Cornec, 4 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.