Opened 9 years ago
Closed 9 years ago
#760 closed defect (invalid)
getfacl argument missing
Reported by: | victor gattegno | Owned by: | Bruno Cornec |
---|---|---|---|
Priority: | normal | Milestone: | 3.0.5 |
Component: | mondo | Version: | 3.0.4 |
Severity: | blocker | Keywords: | -z option getfacl |
Cc: |
Description
I see in Mondo 3.0.4, in libmondo-filelist.c, line 496 :
retval = gen_aux_list(filelist, "getfacl --all-effective -P ", facl_fname)
I think that the \"%s\" is missing, because getfacl without a file name will not work, and because it was in previous versions of Mondo, example, in mondo-3.0.4 20130624040329 test version, in libmondo-filelist.c, line 499 :
gen_aux_list(filelist, "getfacl --all-effective -P \"%s\"", facl_fname)
Attachments (1)
Change History (3)
by , 9 years ago
Attachment: | getafcl.gif added |
---|
comment:1 by , 9 years ago
Well, the way we call getfacl changed between versions, and I move the %s part into the direct call made in the function gen_aux_list:
mr_asprintf(syscall, "%s '%s' 2>> /dev/null", syscall_sprintf, tmp); // " MONDO_LOGFILE);
instead of previously:
mr_asprintf(&syscall, "%s 2>> /dev/null", strtmp); // " MONDO_LOGFILE);
So , all in all it's the same. Now it would be great to understand the blocking factor which could be linked to a strange name, even if I try to do my best to avoid that issue.
List of file names contained in the afio file would then be usefull to check.
comment:2 by , 9 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
I think we can close this one.
getfacl comparison of libmondo-filelist.c (mondo 3.0.4 and previous)