modinfo error in mindi - modprobe impacted

[victor gattegno]

There is an error in mindi :

Line 3233:

for i in loop cdrom ide-cd isofs linear raid0 raid1 raid5 ; do
modinfo 2> /dev/null 1> /dev/null
  if [ $? -eq 0 ]; then
	modprobe $i 2>&1 > /dev/null
  fi
done

It should be :

for i in loop cdrom ide-cd isofs linear raid0 raid1 raid5 ; do
modinfo $i 2> /dev/null 1> /dev/null
  if [ $? -eq 0 ]; then
	modprobe $i 2>&1 > /dev/null
  fi

[victor gattegno]

Otherwise modprobe is never executed, because result of modinfo (executed without a module name) is not 0.

[victor gattegno]

Bruno, if you agree, I will patch the modification in mindi source.

[Bruno Cornec]

This is definitely an error ! Please patch Victor :-)

[victor gattegno]

Through SVN, in "branches" I patched 3.0/mindi/mindi

It is the revision 3095

[Bruno Cornec]

Thanks Victor.

Next time, please write your comment in english, and use the convention #677 for designing the bug report (as you can see, trac creates autmatically a link to it, which is great when you navigate the code afterwards.

Here also mention the revision using brackets around the number to do the same on this side.

So fixed with rev [3095].

[Bruno Cornec]

I've updated the log accordingly to give you an idea.