Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#677 closed defect (fixed)

modinfo error in mindi - modprobe impacted

Reported by: victor gattegno Owned by: victor gattegno
Priority: normal Milestone: 3.0.4
Component: mindi Version: 3.0.3
Severity: normal Keywords: modinfo modprobe
Cc:

Description

There is an error in mindi :

Line 3233:

for i in loop cdrom ide-cd isofs linear raid0 raid1 raid5 ; do
modinfo 2> /dev/null 1> /dev/null
  if [ $? -eq 0 ]; then
	modprobe $i 2>&1 > /dev/null
  fi
done

It should be :

for i in loop cdrom ide-cd isofs linear raid0 raid1 raid5 ; do
modinfo $i 2> /dev/null 1> /dev/null
  if [ $? -eq 0 ]; then
	modprobe $i 2>&1 > /dev/null
  fi

Change History (8)

comment:1 Changed 7 years ago by victor gattegno

Otherwise modprobe is never executed, because result of modinfo (executed without a module name) is not 0.

Last edited 7 years ago by victor gattegno (previous) (diff)

comment:2 Changed 7 years ago by victor gattegno

Bruno, if you agree, I will patch the modification in mindi source.

comment:3 Changed 7 years ago by Bruno Cornec

This is definitely an error ! Please patch Victor :-)

comment:4 Changed 7 years ago by Bruno Cornec

Owner: changed from Bruno Cornec to victor gattegno

comment:5 Changed 7 years ago by victor gattegno

Through SVN, in "branches" I patched 3.0/mindi/mindi

It is the revision 3095

comment:6 Changed 7 years ago by victor gattegno

Resolution: fixed
Status: newclosed

comment:7 Changed 7 years ago by Bruno Cornec

Thanks Victor.

Next time, please write your comment in english, and use the convention #677 for designing the bug report (as you can see, trac creates autmatically a link to it, which is great when you navigate the code afterwards.

Here also mention the revision using brackets around the number to do the same on this side.

So fixed with rev [3095].

comment:8 Changed 7 years ago by Bruno Cornec

I've updated the log accordingly to give you an idea.

Note: See TracTickets for help on using tickets.