mondorestore trys to mount external hard disk device to directory

[Joseph Sylvester]

When restoring an archive (ISO files) located on an external hard disk using mondorestore, the user is prompted to enter the device and path (directory) on that device where the archive (ISO files) are located. Mondorestore attempts to mount the device to the directory, instead of mounting the device to /tmp/isodir first. This action produces an error (sample below): [Main] mondo-rstr-tools.c->iso_fiddly_bits#320: The 'mount' command is 'mount /dev/sde1 -o ro Mondo'. PLEASE report this command to be if you have problems, ok? running: mount /dev/sde1 -o ro Mondo > mondo.tmp.C6QiZw/mondo-run-prog-thing.tmp 2> mondo.tmp.C6QiZw/mondo-run-prog-thing.err

---

fuse: failed to access mountpoint Mondo: No such file or directory

---

...ran with res=5376 Cannot mount the device where the ISO files are stored.

I have attached the mondorestore.log to this report.

Modifying function iso_fiddly_bits in mondo-rstr-tools.c to mount the device to /tmp/isodir instead of attempting to mount the device to the directory eliminated this error message.

[Joseph Sylvester]

Compressed mondorestore.log showing errors mounting device to directory

[Joseph Sylvester]

Replying to jgsylvester:

When restoring an archive (ISO files) located on an external hard disk using mondorestore, the user is prompted to enter the device and path (directory) on that device where the archive (ISO files) are located. Mondorestore attempts to mount the device to the directory, instead of mounting the device to /tmp/isodir first. This action produces an error (sample below): [Main] mondo-rstr-tools.c->iso_fiddly_bits#320: The 'mount' command is 'mount /dev/sde1 -o ro Mondo'. PLEASE report this command to be if you have problems, ok? running: mount /dev/sde1 -o ro Mondo > mondo.tmp.C6QiZw/mondo-run-prog-thing.tmp 2> mondo.tmp.C6QiZw/mondo-run-prog-thing.err

---

fuse: failed to access mountpoint Mondo: No such file or directory

---

...ran with res=5376 Cannot mount the device where the ISO files are stored.

I have attached the mondorestore.log to this report.

Modifying function iso_fiddly_bits in mondo-rstr-tools.c to mount the device to /tmp/isodir instead of attempting to mount the device to the directory eliminated this error message.

I have tested the following changes:

1. file src/mondorestore/mondo-rstr-tools.c, function iso_fiddly_bits(), add to line 315:

/* Need to mount device to /tmp/isodir first */ strcpy(bkpinfo->isodir, "/tmp/isodir");

2. file src/mondorestore/mondo-rstr-tools.c, function iso_fiddly_bits(), change line 317:

mr_strcat(mount_isodir_command, " -o ro %s", bkpinfo->isodir);

to

mr_strcat(mount_isodir_command, " -o rw %s", bkpinfo->isodir);

(change read-only (ro) to read-write (rw). This change is needed to prevent segmentation fault on subsequent launching of mondorestore. I needed to explicitly specify "Read-write" because on my system, leaving out "-o ro" was not the same as "-o rw" as the man page would lead you to believe.

These changes have been throughly tested on my system running Ubuntu Lucid 10.04 64-bit with external hard drives. I am not equipped to test on other configurations.

[Bruno Cornec]

Your patch will for sure break the other modes :-( Indeed there is an issue with ISOs on an external disk.

I think the ro mode comes from the fact you use a NT FS, and connot mount it ro

What would happen if you answer /tmp/isodir to the question "At what path on this device can the ISO files be found?" (that's in fact what you do in your patch).

I guess you're asked later for the subdirectory under which your ISO are anyway ? So maybe it's just giving user a message to indicate where to mount the external HDD on which ISOs are.

[Bruno Cornec]

I produced this patch in between in order to help. Cf: rev [2767]

[Bruno Cornec]

I think it's best to treat all the problem in BR #433 which I had forgotten. So closing for now and discussion can continue in that other one.