Opened 10 years ago

Last modified 4 years ago

#197 reopened enhancement

Count deleted files in compare and show total along with popup changelist.

Reported by: cummings Owned by: bruno
Priority: normal Milestone:
Component: mondo Version: 2.2.4
Severity: normal Keywords:
Cc:

Description

Hi Bruno,

Here's a patch that I tried. I wanted mondorestore compare to explain some of the difference between the count it showed of significant file differences and the number of files that were listed in the non-matching filelist. Maybe this is obvious to everyone else, but load_filelist_into_array had a few different criteria for excluding files from the filelist and I wanted to verify which files it found that were deleted from the system.

In load_filelist_into_array count the files that can't be found now in the file system. Display the total. Record the file names in a 'deleted.files' file.

I hope this is helpful.

Regards, Scott

Attachments (1)

SEND_THIS_IN_diff.newt-specific.c.fix_for_counting_deleted_files (1.4 KB) - added by cummings 10 years ago.
patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by bruno

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in rev [1662]. Will be in 2.2.5. I adapted a bit your patch, so you may want to look at it to check It covers your needs. Thanks a lot for the report.

comment:2 Changed 10 years ago by cummings

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi Bruno,

I tried out the svn version of 2.2.5 (Revision: 1674) using mondoarchive verify.

sudo  mondoarchive -V  -i -s 4400m   -d /media/hdb2 -p mondorescue -G -g

Here's the last few lines that appear on the screen -

BusyBox's sources are available from http://www.busybox.net                                                                  
75 differences found.                                                                                                        
17 files listed in /media/hdb2/mondo.tmp.lY47Fj/changed.files have been deleted                                              
  58 files differ. Hit 'Select' to pick a file. Hit 'Close' to quit the list.                                                

This adds the main info I was after. :)


I have a couple of minor suggestions -

  1. The path to 'changed.files' changes after the program ends to /var/cache/mindi, so maybe that should be listed.
  2. The second part of the message doesn't fit on the screen.
  3. The file tmp1 is erased when the program ends.

i.e.

log_to_screen("%d files listed in %s/changed.files have been deleted since backup was made\nand are referenced in %s", j, bkpinfo->tmpdir,tmp1); 
  • When I close the non-matching files list there are some 'Directory nonexistent ' messages.
sh: cannot create /media/hdb2/mondo.tmp.lY47Fj/mondo-run-prog-thing.tmp: Directory nonexistent                               
                                         dd: opening `/dev/cdrom': No medium found            sh: cannot create /media/hdb2/mondo.tmp.lY47Fj/mondo-run-prog-thing.tmp: Directory nonexistent                                                              
                                                               sh: cannot create /media/hdb2/mondo.tmp.lY47Fj/mondo-run-prog-thing.tmp: Directory nonexistentfrom http://www.busybox.net                                                                  
75 differences found.           Mondoarchive ran OK.                                                                         
17 files listed in /media/hdb2/mondo.tmp.lY47Fj/changed.files have been deleted                                              
75 differences found.                                                                                                        
Mondo Archive has finished its run. Please press ENTER to return to the shell promp                                          

  • when I exit the program I get a Segmentation fault. (which you may have already fixed - I realize this is code under development.)

Thanks, Scott Cummings

comment:3 Changed 10 years ago by bruno

  • Milestone changed from 2.2.5 to 2.2.6

comment:4 Changed 9 years ago by bruno

  • Milestone changed from 2.2.6 to 2.2.7

comment:5 Changed 9 years ago by bruno

  • Milestone changed from 2.2.7 to 2.2.8

comment:6 Changed 9 years ago by bruno

  • Milestone changed from 2.2.8 to 2.2.9

comment:7 Changed 8 years ago by bruno

  • Milestone changed from 2.2.9 to 2.2.10

comment:8 Changed 4 years ago by bruno

  • Milestone 3.1.0 deleted

Milestone 3.1.0 deleted

Note: See TracTickets for help on using tickets.