Changeset 3191 in MondoRescue for branches/3.2/mondo/src/common/libmondo-verify.c

Timestamp:

Sep 25, 2013, 8:55:45 AM (11 years ago)

Author:

Bruno Cornec

Message:

• Lots of memory management backports from 3.1 to 3.2 - still not finished, nor working ATM. the common subdir was done during travel, so this is essentially a backup !

File:

• branches/3.2/mondo/src/common/libmondo-verify.c (modified) (52 diffs)

branches/3.2/mondo/src/common/libmondo-verify.c

@@ -55 +55 @@
     assert(bkpinfo != NULL);
     assert_string_is_neither_NULL_nor_zerolength(mountpoint);
-    sprintf(output, "%s/archives/%d.star.%s", mountpoint, setno,
-            bkpinfo->zip_suffix);
+    sprintf(output, "%s/archives/%d.star.%s", mountpoint, setno, bkpinfo->zip_suffix);
     if (!does_file_exist(output)) {
-        sprintf(output, "%s/archives/%d.afio.%s", mountpoint, setno,
-                bkpinfo->zip_suffix);
+        sprintf(output, "%s/archives/%d.afio.%s", mountpoint, setno, bkpinfo->zip_suffix);
     }
     return (output);
@@ -80 +78 @@
 {
     /*@ buffer ********************************************************** */
-    char *command;
-    char *afio_found_changes;
+    char *command = NULL;
+    char *afio_found_changes = NULL;
 
     /*@ int ************************************************************* */
@@ -89 +87 @@
     long afio_diffs = 0;
 
-    command = malloc(2000);
-    afio_found_changes = malloc(500);
     assert_string_is_neither_NULL_nor_zerolength(changedfiles_fname);
     assert_string_is_neither_NULL_nor_zerolength(ignorefiles_fname);
     assert_string_is_neither_NULL_nor_zerolength(stderr_fname);
 
-    sprintf(afio_found_changes, "%s.afio", ignorefiles_fname);
-    paranoid_system("sync");
-
-/*  sprintf (command,
-       "grep \"afio: \" %s | awk '{j=substr($0,8); i=index(j,\": \");printf \"/%%s\\n\",substr(j,1,i-2);}' | sort -u | grep -v \"incheckentry.*xwait\" | grep -vx \"/afio:.*\" | grep -vx \"/dev/.*\" > %s",
-       stderr_fname, afio_found_changes);
-*/
+    mr_asprintf(afio_found_changes, "%s.afio", ignorefiles_fname);
+    sync();
 
     log_msg(1, "Now scanning log file for 'afio: ' stuff");
-    sprintf(command,
-            "grep \"afio: \" %s | sed 's/afio: //' | grep -vE '^/dev/.*$' >> %s",
-            stderr_fname, afio_found_changes);
+    mr_asprintf(command, "grep \"afio: \" %s | sed 's/afio: //' | grep -vE '^/dev/.*$' >> %s", stderr_fname, afio_found_changes);
     log_msg(2, command);
     res = system(command);
+    mr_free(command);
+
     if (res) {
         log_msg(2, "Warning - failed to think");
@@ -114 +105 @@
 
     log_msg(1, "Now scanning log file for 'star: ' stuff");
-    sprintf(command,
-            "grep \"star: \" %s | sed 's/star: //' | grep -vE '^/dev/.*$' >> %s",
-            stderr_fname, afio_found_changes);
+    mr_asprintf(command, "grep \"star: \" %s | sed 's/star: //' | grep -vE '^/dev/.*$' >> %s", stderr_fname, afio_found_changes);
     log_msg(2, command);
     res = system(command);
+    mr_free(command);
+
     if (res) {
         log_msg(2, "Warning - failed to think");
     }
-//  exclude_nonexistent_files (afio_found_changes);
     afio_diffs = count_lines_in_file(afio_found_changes);
-    sprintf(command,
-            "sort %s %s %s | uniq -c | awk '{ if ($1==\"2\") {print $2;};}' | grep -v \"incheckentry xwait()\" > %s",
-            ignorefiles_fname, afio_found_changes, afio_found_changes,
-            changedfiles_fname);
+    mr_asprintf(command, "sort %s %s %s | uniq -c | awk '{ if ($1==\"2\") {print $2;};}' | grep -v \"incheckentry xwait()\" > %s", ignorefiles_fname, afio_found_changes, afio_found_changes, changedfiles_fname);
+    mr_free(afio_found_changes);
     log_msg(2, command);
     paranoid_system(command);
-    paranoid_free(command);
-    paranoid_free(afio_found_changes);
+    mr_free(command);
     return (afio_diffs);
 }
@@ -151 +138 @@
 
     /*@ buffers ********************************************************* */
-    char *tmp;
+    char *tmp = NULL;
     char *mds = NULL;
 
@@ -162 +149 @@
     assert_string_is_neither_NULL_nor_zerolength(mountpoint);
     assert(bkpinfo != NULL);
-    malloc_string(tmp);
 
     for (set_number = 0;
@@ -175 +161 @@
     if (g_last_afioball_number != set_number - 1) {
         if (set_number == 0) {
-            log_msg(1,
-                    "Weird error in verify_afioballs_on_CD() but it's really a cosmetic error, nothing more");
+            log_msg(1, "Weird error in verify_afioballs_on_CD() but it's really a cosmetic error, nothing more");
         } else {
             retval++;
-            sprintf(tmp, "Warning - missing set(s) between %d and %d\n",
-                    g_last_afioball_number, set_number - 1);
-            log_to_screen(tmp);
+            log_to_screen("Warning - missing set(s) between %d and %d\n", g_last_afioball_number, set_number - 1);
         }
     }
     mds = media_descriptor_string(bkpinfo->backup_media_type);
-    sprintf(tmp, "Verifying %s #%d's tarballs", mds, g_current_media_number);
+    mr_asprintf(tmp, "Verifying %s #%d's tarballs", mds, g_current_media_number);
     mr_free(mds);
 
     open_evalcall_form(tmp);
+    mr_free(tmp);
 
     for (total_sets = set_number;
@@ -208 +192 @@
     g_last_afioball_number = set_number - 1;
     close_evalcall_form();
-    paranoid_free(tmp);
     return (retval);
 }
@@ -227 +210 @@
 
     /*@ buffer ********************************************************** */
-    char *tmp;
-    char *mountpoint;
-//  char ca, cb;
-    char *command;
+    char *tmp = NULL;
+    char *mountpoint = NULL;
+    char *command = NULL;
     char *mds = NULL;
-    char *sz_exe;
+    char *sz_exe = NULL;
     static char *bufblkA = NULL;
     static char *bufblkB = NULL;
@@ -252 +234 @@
     FILE *fin;
     int retval = 0;
-//  long long outlen;
-
-    malloc_string(tmp);
-    malloc_string(mountpoint);
-    malloc_string(command);
-    malloc_string(sz_exe);
+
     if (!bufblkA) {
         if (!(bufblkA = malloc(maxbufsize))) {
@@ -274 +251 @@
     if (bkpinfo->compression_level > 0) {
         if (bkpinfo->use_lzo) {
-            strcpy(sz_exe, "lzop");
+            mr_asprintf(sz_exe, "lzop");
         } else if (bkpinfo->use_gzip) {
-            strcpy(sz_exe, "gzip");
+            mr_asprintf(sz_exe, "gzip");
+        } else if (bkpinfo->use_lzma) {
+            mr_asprintf(sz_exe, "lzma");
         } else {
-            strcpy(sz_exe, "bzip2");
-        }
-    } else {
-        sz_exe[0] = '\0';
+            mr_asprintf(sz_exe, "bzip2");
+        }
     }
 
     log_it("before vsbf");
     mds = media_descriptor_string(bkpinfo->backup_media_type);
-    sprintf(tmp, "Verifying %s#%d's big files", mds, g_current_media_number);
+    mr_asprintf(tmp, "Verifying %s#%d's big files", mds, g_current_media_number);
     mr_free(mds);
 
     open_evalcall_form(tmp);
+    mr_free(tmp);
+
     log_it("after vsbf");
-    sprintf(mountpoint, "%s/archives", mtpt);
+    mr_asprintf(mountpoint, "%s/archives", mtpt);
     if (last_bigfile_num == -1) {
         bigfile_num = 0;
@@ -302 +281 @@
         slice_num = last_slice_num + 1;
     }
-    while (does_file_exist
-           (slice_fname
-            (bigfile_num, slice_num, mountpoint, bkpinfo->zip_suffix))
+    while (does_file_exist(slice_fname(bigfile_num, slice_num, mountpoint, bkpinfo->zip_suffix))
            ||
-           does_file_exist(slice_fname
-                           (bigfile_num, slice_num, mountpoint, ""))) {
+           does_file_exist(slice_fname(bigfile_num, slice_num, mountpoint, ""))) {
         // handle slices until end of CD
         if (slice_num == 0) {
-            log_msg(2, "ISO=%d  bigfile=%ld --START--",
-                    g_current_media_number, bigfile_num);
-            if (!
-                (fin =
-                 fopen(slice_fname(bigfile_num, slice_num, mountpoint, ""),
-                       "r"))) {
+            log_msg(2, "ISO=%d  bigfile=%ld --START--", g_current_media_number, bigfile_num);
+            if (! (fin = fopen(slice_fname(bigfile_num, slice_num, mountpoint, ""), "r"))) {
                 log_msg(2, "Cannot open bigfile's info file");
             } else {
-                if (fread
-                    ((void *) &biggiestruct, 1, sizeof(biggiestruct),
-                     fin) < sizeof(biggiestruct)) {
+                if (fread ((void *) &biggiestruct, 1, sizeof(biggiestruct), fin) < sizeof(biggiestruct)) {
                     log_msg(2, "Unable to get biggiestruct");
                 }
                 paranoid_fclose(fin);
             }
-            sprintf(tmp, "%s/%s", bkpinfo->restore_path,
-                    biggiestruct.filename);
-            log_msg(2, "Opening biggiefile #%ld - '%s'", bigfile_num, tmp);
-            if (!(forig = fopen(tmp, "r"))) {
-                log_msg(2, "Failed to open bigfile. Darn.");
-                log_to_screen("%s/%s not found on live filesystem",
-                            bkpinfo->restore_path,
-                            biggiestruct.filename);
-                mr_asprintf(mds, "echo \"%s/%s not found\" >> %s/biggies.changed",
-                            bkpinfo->restore_path,
-                            biggiestruct.filename,
-                            bkpinfo->tmpdir);
-                paranoid_system(mds);
-                paranoid_free(mds);
-
-                bigfile_num++;
-                slice_num = 0;
-                retval++;
+            if (bkpinfo->restore_path) {
+                mr_asprintf(tmp, "%s/%s", bkpinfo->restore_path, biggiestruct.filename);
+                log_msg(2, "Opening biggiefile #%ld - '%s'", bigfile_num, tmp);
+                forig = fopen(tmp, "r");
+                mr_free(tmp);
+    
+                if (!forig) {
+                    log_msg(2, "Failed to open bigfile. Darn.");
+                    log_to_screen("%s/%s not found on live filesystem", bkpinfo->restore_path, biggiestruct.filename);
+                    mr_asprintf(tmp, "echo \"%s/%s not found\" >> %s/biggies.changed", bkpinfo->restore_path, biggiestruct.filename, bkpinfo->tmpdir);
+                    paranoid_system(tmp);
+                    mr_free(tmp);
+
+                    bigfile_num++;
+                    slice_num = 0;
+                    retval++;
+                } else {
+                    slice_num++;
+                }
             } else {
-                slice_num++;
+                log_it("Unable to open bigfile as restore_path is NULL");
             }
         } else if (does_file_exist(slice_fname(bigfile_num, slice_num, mountpoint, "")) &&
@@ -354 +325 @@
             slice_num = 0;
         } else {
-            log_msg(2, "ISO=%d  bigfile=%ld  slice=%ld",
-                    g_current_media_number, bigfile_num, slice_num);
-            if (!does_file_exist(slice_fname(bigfile_num, slice_num, mountpoint, ""))) {
-                sprintf(command, "%s -dc %s 2>> %s",
-                        sz_exe,
-                        slice_fname(bigfile_num, slice_num, mountpoint, bkpinfo->zip_suffix),
-                        MONDO_LOGFILE);
+            log_msg(2, "ISO=%d  bigfile=%ld  slice=%ld", g_current_media_number, bigfile_num, slice_num);
+            if ((!does_file_exist(slice_fname(bigfile_num, slice_num, mountpoint, ""))) && (sz_exe != NULL)) {
+                mr_asprintf(command, "%s -dc %s 2>> %s", sz_exe, slice_fname(bigfile_num, slice_num, mountpoint, bkpinfo->zip_suffix), MONDO_LOGFILE);
             } else {
-                sprintf(command, "cat %s 2>> %s",
-                        slice_fname(bigfile_num, slice_num, mountpoint, ""), MONDO_LOGFILE);
+                mr_asprintf(command, "cat %s 2>> %s", slice_fname(bigfile_num, slice_num, mountpoint, ""), MONDO_LOGFILE);
             }
-            if ((pin = popen(command, "r"))) {
+            pin = popen(command, "r");
+            mr_free(command);
+            if (pin) {
                 res = 0;
                 while (!feof(pin)) {
@@ -404 +372 @@
         }
     }
+    mr_free(mountpoint);
+    mr_free(sz_exe);
+
     last_bigfile_num = bigfile_num;
     last_slice_num = slice_num - 1;
@@ -416 +387 @@
         paranoid_free(bufblkB);
     }
-    paranoid_free(tmp);
-    paranoid_free(command);
-    paranoid_free(sz_exe);
-    paranoid_free(mountpoint);
     return (0);
 }
@@ -442 +409 @@
 {
     /*@ buffers ********************************************************* */
-    char *command;
-    char *outlog;
-    char *tmp;
-    char *p;
+    char *command = NULL;
+    char *outlog = NULL;
+    char *tmp = NULL;
+    char *p = NULL;
 
     /*@ pointers ******************************************************* */
@@ -462 +429 @@
 
     log_it("Verifying fileset '%s'", tarball_fname);
-    /*  chdir("/"); */
-    sprintf(outlog, "%s/afio.log", bkpinfo->tmpdir);
-/* if programmer forgot to say which compression thingy to use then find out */
-    if (strstr(tarball_fname, ".lzo")
-        && strcmp(bkpinfo->zip_suffix, "lzo")) {
+    mr_asprintf(outlog, "%s/afio.log", bkpinfo->tmpdir);
+    /* if programmer forgot to say which compression thingy to use then find out */
+    if (strstr(tarball_fname, ".lzo") && strcmp(bkpinfo->zip_suffix, "lzo")) {
         log_msg(2, "OK, I'm going to start using lzop.");
         strcpy(bkpinfo->zip_exe, "lzop");
@@ -472 +437 @@
         bkpinfo->use_lzo = TRUE;
         bkpinfo->use_gzip = FALSE;
-    }
-    if (strstr(tarball_fname, ".gz")
-        && strcmp(bkpinfo->zip_suffix, "gz")) {
+        bkpinfo->use_lzma = FALSE;
+    }
+    if (strstr(tarball_fname, ".gz") && strcmp(bkpinfo->zip_suffix, "gz")) {
         log_msg(2, "OK, I'm going to start using gzip.");
         strcpy(bkpinfo->zip_exe, "gzip");
@@ -480 +445 @@
         bkpinfo->use_lzo = FALSE;
         bkpinfo->use_gzip = TRUE;
-    }
-    if (strstr(tarball_fname, ".bz2")
-        && strcmp(bkpinfo->zip_suffix, "bz2")) {
+        bkpinfo->use_lzma = FALSE;
+    }
+    if (strstr(tarball_fname, ".bz2") && strcmp(bkpinfo->zip_suffix, "bz2")) {
         log_msg(2, "OK, I'm going to start using bzip2.");
         strcpy(bkpinfo->zip_exe, "bzip2");
@@ -488 +453 @@
         bkpinfo->use_lzo = FALSE;
         bkpinfo->use_gzip = FALSE;
+        bkpinfo->use_lzma = FALSE;
+    }
+    if (strstr(tarball_fname, ".lzma") && strcmp(bkpinfo->zip_suffix, "lzma")) {
+        log_msg(2, "OK, I'm going to start using lzma.");
+        strcpy(bkpinfo->zip_exe, "lzma");
+        strcpy(bkpinfo->zip_suffix, "lzma");
+        bkpinfo->use_lzo = FALSE;
+        bkpinfo->use_gzip = FALSE;
+        bkpinfo->use_lzma = TRUE;
+    }
+    if (bkpinfo->zip_exe == NULL) {
+        strcpy(bkpinfo->zip_exe, "none");
+    }
+    if (bkpinfo->zip_suffix == NULL) {
+        strcpy(bkpinfo->zip_suffix, "");
     }
     unlink(outlog);
@@ -493 +473 @@
         bkpinfo->use_star = TRUE;
         if (strstr(tarball_fname, ".bz2"))
-            sprintf(command,
-                    "star -sparse -diff diffopts=mode,size,data file=%s %s >> %s 2>> %s",
-                    tarball_fname,
-                    (strstr(tarball_fname, ".bz2")) ? "-bz" : " ", outlog,
-                    outlog);
+            mr_asprintf(command, "star -sparse -diff diffopts=mode,size,data file=%s %s >> %s 2>> %s", tarball_fname, (strstr(tarball_fname, ".bz2")) ? "-bz" : " ", outlog, outlog);
     } else {
         bkpinfo->use_star = FALSE;
-        sprintf(command, "afio -r -P %s -Z %s >> %s 2>> %s",
-                bkpinfo->zip_exe, tarball_fname, outlog, outlog);
+        /* Here we suppose that there is always a compression program called */
+        if (bkpinfo->zip_exe) {
+            mr_asprintf(command, "afio -r -P %s -Z %s >> %s 2>> %s", bkpinfo->zip_exe, tarball_fname, outlog, outlog);
+        } else {
+            mr_asprintf(command, "afio -r -Z %s >> %s 2>> %s", tarball_fname, outlog, outlog);
+        }
     }
     log_msg(6, "command=%s", command);
     paranoid_system(command);
+    mr_free(command);
+
     if (length_of_file(outlog) < 10) {
-        sprintf(command, "cat %s >> %s", outlog, MONDO_LOGFILE);
+        mr_asprintf(command, "cat %s >> %s", outlog, MONDO_LOGFILE);
     } else {
-        sprintf(command, "cut -d: -f%d %s | sort -u",
-                (bkpinfo->use_star) ? 1 : 2, outlog);
+        mr_asprintf(command, "cut -d: -f%d %s | sort -u", (bkpinfo->use_star) ? 1 : 2, outlog);
         pin = popen(command, "r");
         if (pin) {
-            for (p = fgets(tmp, MAX_STR_LEN, pin); !feof(pin) && (p != NULL);
-                 p = fgets(tmp, MAX_STR_LEN, pin)) {
+            for (mr_getline(tmp, pin); !feof(pin); mr_getline(tmp, pin)) {
                 if (bkpinfo->use_star) {
                     if (!strstr(tmp, "diffopts=")) {
-                        while (strlen(tmp) > 0
-                               && tmp[strlen(tmp) - 1] < 32) {
+                        while (strlen(tmp) > 0 && tmp[strlen(tmp) - 1] < 32) {
                             tmp[strlen(tmp) - 1] = '\0';
                         }
                         if (strchr(tmp, '/')) {
                             if (!diffs) {
-                                log_msg(0, "'%s' - differences found",
-                                        tarball_fname);
+                                log_msg(0, "'%s' - differences found", tarball_fname);
                             }
-                            log_msg(0, "star: /%s",
-                                    strip_afio_output_line(tmp));
+                            log_msg(0, "star: /%s", strip_afio_output_line(tmp));
                             diffs++;
                         }
@@ -532 +509 @@
                 } else {
                     if (!diffs) {
-                        log_msg(0, "'%s' - differences found",
-                                tarball_fname);
+                        log_msg(0, "'%s' - differences found", tarball_fname);
                     }
                     log_msg(0, "afio: /%s", strip_afio_output_line(tmp));
                     diffs++;
                 }
+                mr_free(tmp);
             }
+            mr_free(tmp);
             paranoid_pclose(pin);
         } else {
@@ -544 +522 @@
         }
     }
-    /*  chdir(old_pwd); */
-    //  sprintf (tmp, "uniq -u %s >> %s", "/tmp/mondo-verify.err", MONDO_LOGFILE);
-    //  paranoid_system (tmp);
-    //  unlink ("/tmp/mondo-verify.err");
-    paranoid_free(command);
-    paranoid_free(outlog);
-    paranoid_free(tmp);
+    mr_free(command);
+    mr_free(outlog);
     return (0);
 }
@@ -604 +577 @@
 
     /*@ buffers ********************************************************** */
-    char *tmp;
-    char *tarball_fname;
+    char *tmp = NULL;
+    char *tarball_fname = NULL;
 
     /*@ pointers ********************************************************* */
     char *p;
 
-    malloc_string(tmp);
-    malloc_string(tarball_fname);
     assert(bkpinfo != NULL);
     assert_string_is_neither_NULL_nor_zerolength(orig_fname);
@@ -621 +592 @@
         p++;
     }
-    sprintf(tmp, "mkdir -p %s/tmpfs", bkpinfo->tmpdir);
+    mr_asprintf(tmp, "mkdir -p %s/tmpfs", bkpinfo->tmpdir);
     paranoid_system(tmp);
-    sprintf(tarball_fname, "%s/tmpfs/temporary-%s", bkpinfo->tmpdir, p);
-    sprintf(tmp, "Temporarily copying file from tape to '%s'",
-            tarball_fname);
-/*  log_it(tmp); */
+    mr_free(tmp);
+
+    mr_asprintf(tarball_fname, "%s/tmpfs/temporary-%s", bkpinfo->tmpdir, p);
     read_file_from_stream_to_file(tarball_fname, size);
     res = verify_a_tarball(tarball_fname);
     if (res) {
-        sprintf(tmp,
-                "Afioball '%s' no longer matches your live filesystem", p);
-        log_msg(0, tmp);
+        log_msg(0, "Afioball '%s' no longer matches your live filesystem", p);
         retval++;
     }
     unlink(tarball_fname);
-    paranoid_free(tmp);
-    paranoid_free(tarball_fname);
+    mr_free(tarball_fname);
     return (retval);
 }
@@ -660 +627 @@
 
     /*@ char ************************************************************ */
-    char *test_file;
-    char *biggie_cksum;
-    char *orig_cksum;
-    char *tmp;
-    char *slice_fnam;
+    char *test_file = NULL;
+    char *biggie_cksum = NULL;
+    char *orig_cksum = NULL;
+    char *tmp = NULL;
+    char *slice_fnam = NULL;
 
     /*@ pointers ******************************************************** */
@@ -672 +639 @@
     long long slice_siz;
 
-    malloc_string(test_file);
-    malloc_string(biggie_cksum);
-    malloc_string(orig_cksum);
-    malloc_string(tmp);
     malloc_string(slice_fnam);
     assert(bkpinfo != NULL);
@@ -686 +649 @@
         p++;
     }
-    sprintf(test_file, "%s/temporary-%s", bkpinfo->tmpdir, p);
-    sprintf(tmp,
-            "Temporarily copying biggiefile %s's slices from tape to '%s'",
-            p, test_file);
-/*  log_it(tmp); */
+    mr_asprintf(test_file, "%s/temporary-%s", bkpinfo->tmpdir, p);
     for (res =
          read_header_block_from_stream(&slice_siz, slice_fnam, &ctrl_chr);
          ctrl_chr != BLK_STOP_A_BIGGIE;
          res =
-         read_header_block_from_stream(&slice_siz, slice_fnam,
-                                       &ctrl_chr)) {
+         read_header_block_from_stream(&slice_siz, slice_fnam, &ctrl_chr)) {
         if (ctrl_chr != BLK_START_AN_AFIO_OR_SLICE) {
             wrong_marker(BLK_START_AN_AFIO_OR_SLICE, ctrl_chr);
@@ -703 +661 @@
         unlink(test_file);
         res =
-            read_header_block_from_stream(&slice_siz, slice_fnam,
-                                          &ctrl_chr);
+            read_header_block_from_stream(&slice_siz, slice_fnam, &ctrl_chr);
         if (ctrl_chr != BLK_STOP_AN_AFIO_OR_SLICE) {
             log_msg(2, "test_file = %s", test_file);
@@ -712 +669 @@
         retval += res;
     }
-    strcpy(biggie_cksum, slice_fnam);
+    mr_asprintf(biggie_cksum, "%s", slice_fnam);
     if (biggie_cksum[0] != '\0') {
-        strcpy(orig_cksum, calc_checksum_of_file(biggie_fname));
+        mr_asprintf(orig_cksum, "%s", calc_checksum_of_file(biggie_fname));
         if (strcmp(biggie_cksum, orig_cksum)) {
-            sprintf(tmp, "orig cksum=%s; curr cksum=%s", biggie_cksum,
-                    orig_cksum);
-            log_msg(2, tmp);
-            sprintf(tmp, "%s has changed on live filesystem",
-                    biggie_fname);
-            log_to_screen(tmp);
-            sprintf(tmp, "echo \"%s\" >> %s/biggies.changed",
-                    biggie_fname, bkpinfo->tmpdir);
+            log_msg(2, "orig cksum=%s; curr cksum=%s", biggie_cksum, orig_cksum);
+            log_to_screen("%s has changed on live filesystem", biggie_fname);
+
+            mr_asprintf(tmp, "echo \"%s\" >> %s/biggies.changed", biggie_fname, bkpinfo->tmpdir);
             paranoid_system(tmp);
-        }
-    }
-    paranoid_free(test_file);
-    paranoid_free(biggie_cksum);
-    paranoid_free(orig_cksum);
-    paranoid_free(tmp);
+            mr_free(tmp);
+        }
+        mr_free(orig_cksum);
+    }
+    mr_free(biggie_cksum);
+    mr_free(test_file);
     paranoid_free(slice_fnam);
     return (retval);
@@ -739 +692 @@
  * Verify all afioballs from the opened tape/CD stream.
  * @param bkpinfo The backup information structure. Fields used:
- * - @c bkpinfo->restore_path
  * - @c bkpinfo->tmpdir
  *
@@ -754 +706 @@
 
     /*@ buffers ***************************************************** */
-    char *tmp;
+    char *tmp = NULL;
     char *fname;
     char *curr_xattr_list_fname;
@@ -763 +715 @@
 
     assert(bkpinfo != NULL);
-    malloc_string(tmp);
     malloc_string(fname);
     malloc_string(curr_xattr_list_fname);
@@ -816 +767 @@
             wrong_marker(BLK_START_AN_AFIO_OR_SLICE, ctrl_chr);
         }
-        sprintf(tmp, "Verifying fileset #%ld", current_afioball_number);
-        /*log_it(tmp); */
+        mr_asprintf(tmp, "Verifying fileset #%ld", current_afioball_number);
         update_progress_form(tmp);
+        mr_free(tmp);
+
         res = verify_an_afioball_from_stream(fname, size);
         if (res) {
-            sprintf(tmp, "Afioball %ld differs from live filesystem",
-                    current_afioball_number);
-            log_to_screen(tmp);
+            log_to_screen("Afioball %ld differs from live filesystem", current_afioball_number);
         }
         retval += res;
@@ -835 +785 @@
     log_msg(1, "All done with afioballs");
     close_progress_form();
-    paranoid_free(tmp);
     paranoid_free(fname);
     paranoid_free(curr_xattr_list_fname);
@@ -863 +812 @@
 
     /*@ buffers ******************************************************** */
-    char *tmp;
-    char *orig_fname, *logical_fname;
-    char *comment;
-    char *curr_xattr_list_fname;
-    char *curr_acl_list_fname;
+    char *orig_fname;
+    char *logical_fname = NULL;
+    char *comment = NULL;
+    char *curr_xattr_list_fname = NULL;
+    char *curr_acl_list_fname = NULL;
     /*@ pointers ******************************************************* */
     char *p;
@@ -875 +824 @@
 
     assert(bkpinfo != NULL);
-    malloc_string(tmp);
     malloc_string(orig_fname);
-    malloc_string(logical_fname);
-    malloc_string(comment);
     malloc_string(curr_xattr_list_fname);
     malloc_string(curr_acl_list_fname);
@@ -890 +836 @@
             bkpinfo->tmpdir);
     }
-    sprintf(comment, "Verifying all bigfiles.");
+    mr_asprintf(comment, "Verifying all bigfiles.");
     log_to_screen(comment);
-    sprintf(tmp, "%s/biggielist.txt", bkpinfo->tmpdir);
-//  noof_biggiefiles = count_lines_in_file (tmp); // pointless
     res = read_header_block_from_stream(&size, orig_fname, &ctrl_chr);
     if (ctrl_chr != BLK_START_BIGGIEFILES) {
@@ -911 +855 @@
                        "Please wait. This may take some time.", "",
                        noof_biggiefiles);
+    mr_free(comment);
+
     for (res = read_header_block_from_stream(&size, orig_fname, &ctrl_chr);
          ctrl_chr != BLK_STOP_BIGGIEFILES;
@@ -925 +871 @@
             p++;
         }
-        sprintf(comment, "Verifying bigfile #%ld (%ld K)",
-                current_biggiefile_number, (long) size >> 10);
+        mr_asprintf(comment, "Verifying bigfile #%ld (%ld K)", current_biggiefile_number, (long) size >> 10);
         update_progress_form(comment);
-        sprintf(logical_fname, "%s/%s", bkpinfo->restore_path, orig_fname);
-        res =
-            verify_a_biggiefile_from_stream(logical_fname, size);
-        retval += res;
+        mr_free(comment);
+
+        if (bkpinfo->restore_path) {
+            mr_asprintf(logical_fname, "%s/%s", bkpinfo->restore_path, orig_fname);
+            res = verify_a_biggiefile_from_stream(logical_fname, size);
+            mr_free(logical_fname);
+            retval += res;
+        } else {
+            log_it("Unable to verify bigfile as restore_path is NULL");
+        }
+
         current_biggiefile_number++;
         g_current_progress++;
@@ -937 +889 @@
     close_progress_form();
     paranoid_free(orig_fname);
-    paranoid_free(logical_fname);
     paranoid_free(curr_xattr_list_fname);
     paranoid_free(curr_acl_list_fname);
-    paranoid_free(comment);
-    paranoid_free(tmp);
     return (retval);
 }
@@ -951 +900 @@
  * Verify the USB device
  * @param bkpinfo The backup information structure. Fields used:
- * - @c bkpinfo->isodir
  * - @c bkpinfo->media_device
  * - @c bkpinfo->tmpdir
@@ -981 +929 @@
     assert(bkpinfo != NULL);
 
+    if (bkpinfo->media_device == NULL) {
+        return(1);
+    }
+
     mr_asprintf(fname, "%s1", bkpinfo->media_device);
     if (is_this_device_mounted(fname)) {
@@ -1032 +984 @@
 #endif
     {
-        mr_asprintf(tmp, "%s failed; unable to unmount USB device\n", tmp1);
-        log_to_screen(tmp);
-        paranoid_free(tmp);
+        log_to_screen("%s failed; unable to unmount USB device\n", tmp1);
         retval++;
     } else {
         log_msg(2, "OK, I've unmounted the USB device\n");
     }
-    paranoid_free(tmp1);
-    paranoid_free(mountpoint);
+    mr_free(tmp1);
+    mr_free(mountpoint);
     return (retval);
 }
@@ -1066 +1016 @@
 
     /*@ buffers ******************************************************** */
-    char *mountpoint;
-    char *command;
-    char *tmp;
-    char *fname;
+    char *mountpoint = NULL;
+    char *command = NULL;
+    char *tmp = NULL;
+    char *fname = NULL;
 #ifdef __FreeBSD__
     char mdd[32];
@@ -1079 +1029 @@
 #endif
 
-    command = malloc(2000);
-    malloc_string(mountpoint);
-    malloc_string(tmp);
-    malloc_string(fname);
-
     assert(bkpinfo != NULL);
 
-    sprintf(mountpoint, "%s/cdrom", bkpinfo->tmpdir);
-    sprintf(fname, "%s/%s/%s-%d.iso", bkpinfo->isodir, bkpinfo->netfs_remote_dir,
-            bkpinfo->prefix, g_current_media_number);
+    if (bkpinfo->media_device == NULL) {
+        return(1);
+    }
+
+    mr_asprintf(mountpoint, "%s/cdrom", bkpinfo->tmpdir);
+    if (((bkpinfo->isodir == NULL) && (bkpinfo->netfs_remote_dir == NULL)) || (bkpinfo->prefix == NULL)) {
+        fatal_error("No iso filename preparation possible");
+    }
+    if (bkpinfo->netfs_remote_dir) {
+        // NETFS
+        mr_asprintf(fname, "%s/%s/%s-%d.iso", bkpinfo->isodir, bkpinfo->netfs_remote_dir, bkpinfo->prefix, g_current_media_number);
+    } else {
+        // ISO
+        mr_asprintf(fname, "%s/%s-%d.iso", bkpinfo->isodir, bkpinfo->prefix, g_current_media_number);
+    }
 
     mkdir(mountpoint, 1777);
     sync();
     if (!does_file_exist(fname)) {
-        sprintf(tmp,
-                "%s not found; assuming you backed up to CD; verifying CD...",
-                fname);
-        log_msg(2, tmp);
+        log_msg(2, "%s not found; assuming you backed up to CD; verifying CD...", fname);
         if (bkpinfo->manual_cd_tray) {
             popup_and_OK("Please push CD tray closed.");
@@ -1102 +1056 @@
         if (find_and_mount_actual_cd(mountpoint)) {
             log_to_screen("failed to mount actual CD");
+            mr_free(mountpoint);
+            mr_free(fname);
             return (1);
         }
     } else {
-        sprintf(tmp, "%s found; verifying ISO...", fname);
+        log_msg(2, "%s found; verifying ISO...", fname);
 #ifdef __FreeBSD__
         ret = 0;
@@ -1111 +1067 @@
         mddevice = make_vn(fname);
         if (ret) {
-            sprintf(tmp, "make_vn of %s failed; unable to verify ISO\n",
-                    fname);
-            log_to_screen(tmp);
+            log_to_screen("make_vn of %s failed; unable to verify ISO\n", fname);
+            mr_free(mountpoint);
+            mr_free(fname);
             return (1);
         }
-        sprintf(command, "mount_cd9660 %s %s", mddevice, mountpoint);
+        mr_asprintf(command, "mount_cd9660 %s %s", mddevice, mountpoint);
 #else
-        sprintf(command, "mount -o loop,ro -t iso9660 %s %s", fname,
-                mountpoint);
+        mr_asprintf(command, "mount -o loop,ro -t iso9660 %s %s", fname, mountpoint);
 #endif
         if (run_program_and_log_output(command, FALSE)) {
-            sprintf(tmp, "%s failed; unable to mount ISO image\n",
-                    command);
-            log_to_screen(tmp);
+            log_to_screen("%s failed; unable to mount ISO image\n", command);
+            mr_free(mountpoint);
+            mr_free(command);
+            mr_free(fname);
             return (1);
         }
+        mr_free(command);
     }
     log_msg(2, "OK, I've mounted the ISO/CD\n");
-    sprintf(tmp, "%s/archives/NOT-THE-LAST", mountpoint);
+    mr_asprintf(tmp, "%s/archives/NOT-THE-LAST", mountpoint);
     if (!does_file_exist(tmp)) {
         log_msg
@@ -1141 +1098 @@
 */
     }
+    mr_free(tmp);
+
     verify_afioballs_on_CD(mountpoint);
     log_it("before verify_all_slices");
@@ -1147 +1106 @@
 #ifdef __FreeBSD__
     ret = 0;
-    sprintf(command, "umount -d %s", mountpoint);
+    mr_asprintf(command, "umount -d %s", mountpoint);
     ret += system(command);
     ret += kick_vn(mddevice);
-    if (ret)
+    if (ret) {
 #else
-    sprintf(command, "umount -d %s", mountpoint);
-    if (system(command))
+    mr_asprintf(command, "umount -d %s", mountpoint);
+    if (system(command)) {
 #endif
-    {
-        sprintf(tmp, "%s failed; unable to unmount ISO image\n", command);
-        log_to_screen(tmp);
+        log_to_screen("%s failed; unable to unmount ISO image\n", command);
+
         retval++;
     } else {
         log_msg(2, "OK, I've unmounted the ISO file\n");
     }
+    mr_free(mountpoint);
+    mr_free(command);
+
     if (!does_file_exist(fname)) {
-        sprintf(command, "umount -d %s", bkpinfo->media_device);
+        mr_asprintf(command, "umount -d %s", bkpinfo->media_device);
         run_program_and_log_output(command, 2);
-        if (!bkpinfo->please_dont_eject
-            && eject_device(bkpinfo->media_device)) {
+        mr_free(command);
+
+        if (!bkpinfo->please_dont_eject && eject_device(bkpinfo->media_device)) {
             log_msg(2, "Failed to eject CD-ROM drive");
         }
     }
-    paranoid_free(command);
-    paranoid_free(mountpoint);
-    paranoid_free(tmp);
-    paranoid_free(fname);
+    mr_free(fname);
     return (retval);
 }
@@ -1191 +1150 @@
 
     /*@ buffers ******************************************************** */
-    char tmp[MAX_STR_LEN];
-    char changed_files_fname[MAX_STR_LEN];
+    char *tmp = NULL;
+    char *changed_files_fname = NULL;
 
     /*@ long *********************************************************** */
@@ -1206 +1165 @@
     retval += verify_biggiefiles_from_stream();
 /* find the final blocks */
-    paranoid_system("sync");
+    sync();
     sleep(2);
     closein_tape();
 /* close tape; exit */
 //  fclose(g_tape_stream); <-- not needed; is handled by closein_tape()
-    sprintf(tmp, "rm -f %s/biggies.changed %s/changed.files 2> /dev/null", bkpinfo->tmpdir, bkpinfo->tmpdir);
+    mr_asprintf(tmp, "rm -f %s/biggies.changed %s/changed.files 2> /dev/null", bkpinfo->tmpdir, bkpinfo->tmpdir);
     paranoid_system(tmp);
-    sprintf(changed_files_fname, "%s/changed.files", bkpinfo->tmpdir);
-    sprintf(tmp,
-            "grep -E '^%s:.*$' %s | cut -d'\"' -f2 | sort -u | awk '{print \"/\"$0;};' | tr -s '/' '/' | grep -v \"(total of\" | grep -v \"incheckentry.*xwait\" | grep -vE '^/afio:.*$' | grep -vE '^dev/.*$'  > %s",
-            (bkpinfo->use_star) ? "star" : "afio", MONDO_LOGFILE, 
-            changed_files_fname);
+    mr_free(tmp);
+
+    mr_asprintf(changed_files_fname, "%s/changed.files", bkpinfo->tmpdir);
+    mr_asprintf(tmp, "grep -E '^%s:.*$' %s | cut -d'\"' -f2 | sort -u | awk '{print \"/\"$0;};' | tr -s '/' '/' | grep -v \"(total of\" | grep -v \"incheckentry.*xwait\" | grep -vE '^/afio:.*$' | grep -vE '^dev/.*$'  > %s", (bkpinfo->use_star) ? "star" : "afio", MONDO_LOGFILE, changed_files_fname);
     log_msg(2, "Running command to derive list of changed files");
     log_msg(2, tmp);
     if (system(tmp)) {
-        if (does_file_exist(changed_files_fname)
-            && length_of_file(changed_files_fname) > 2) {
-            log_to_screen
-                ("Warning - unable to check logfile to derive list of changed files");
+        if (does_file_exist(changed_files_fname) && length_of_file(changed_files_fname) > 2) {
+            log_to_screen("Warning - unable to check logfile to derive list of changed files");
         } else {
-            log_to_screen
-                ("No differences found. Therefore, no 'changed.files' text file.");
-        }
-    }
-    sprintf(tmp, "cat %s/biggies.changed >> %s", bkpinfo->tmpdir, changed_files_fname);
+            log_to_screen("No differences found. Therefore, no 'changed.files' text file.");
+        }
+    }
+    mr_free(tmp);
+
+    mr_asprintf(tmp, "cat %s/biggies.changed >> %s", bkpinfo->tmpdir, changed_files_fname);
     paranoid_system(tmp);
+    mr_free(tmp);
 
     diffs = count_lines_in_file(changed_files_fname);
     if (diffs > 0) {
-        sprintf(tmp, "cp -f %s %s/changed.files", changed_files_fname,
-                MONDO_CACHE);
+        mr_asprintf(tmp, "cp -f %s %s/changed.files", changed_files_fname, MONDO_CACHE);
         run_program_and_log_output(tmp, FALSE);
-        sprintf(tmp,
-                "%ld files differed from live filesystem; type less %s or less %s/changed.files to see",
-                diffs, changed_files_fname, MONDO_CACHE);
-        log_msg(0, tmp);
+        mr_free(tmp);
+
+        log_msg(0, "%ld files differed from live filesystem; type less %s or less %s/changed.files to see", diffs, changed_files_fname, MONDO_CACHE);
         log_to_screen("See "MONDO_CACHE"/changed.files for a list of nonmatching files.");
         log_to_screen("The files probably changed on filesystem, not on backup media.");
-        //      retval++;
-    }
+    }
+    mr_free(changed_files_fname);
     return (retval);
 }