Changeset 1644 in MondoRescue for branches/2.2.5/mondo/src/common/libmondo-filelist.c

Timestamp:

Sep 23, 2007, 2:41:29 AM (17 years ago)

Author:

Bruno Cornec

Message:

Apply patch from Andree Leidenfrost, modified a bit to use bkpinfo->tmpdir instead of /tmp
or MINDI_CACHE when appropriate. Fix security issues in mondo
Thanks al ot Andree for catching all those issues.
Will not compile needs more work as bkpinfo->tmpdir isn't available everywhere
Should become a global in 3.x when only containing pointers.

File:

• branches/2.2.5/mondo/src/common/libmondo-filelist.c (modified) (2 diffs)

branches/2.2.5/mondo/src/common/libmondo-filelist.c

@@ -268 +268 @@
     malloc_string(tmp_fname);
     malloc_string(command);
-    sprintf(tmp_fname, "/tmp/sort.%d.%d.%d", (int) (random() % 32768),
-            (int) (random() % 32768), (int) (random() % 32768));
+    sprintf(tmp_fname, "%s/sortfile", bkpinfo->tmpdir);
 
     if (!does_file_exist(orig_fname)) {
@@ -683 +682 @@
     malloc_string(syscall_pin);
     malloc_string(syscall_pout);
-    sprintf(masklist, "/tmp/%d.%d.mask", (int) (random() % 32768),
-            (int) (random() % 32768));
+    sprintf(masklist, "%s/masklist", bkpinfo->tmpdir);
     sprintf(command, "cp -f %s %s", orig_msklist, masklist);
     run_program_and_log_output(command, 1);