Changeset 679 in MondoRescue

Timestamp:

Jun 25, 2006, 3:52:27 AM (18 years ago)

Author:

andree

Message:

Avoid false alerts about growisofs not running under sudo. This is
achieved by examining the growisofs binary and searching exactly one
occurrence of the string SUDO_COMMAND. This test is designed to
avoid false positives. Note that this check is only required for
growisofs and not for other tools that may be used in the future to
write DVDs.

To enhance usability, the associated error message will now also appear
in a pop-up rather than just as part of a bunch of diagnostics output on
the command line.

File:

• branches/stable/mondo/mondo/common/libmondo-tools.c (modified) (1 diff)

branches/stable/mondo/mondo/common/libmondo-tools.c

@@ -698 +698 @@
         }
         if (getenv ("SUDO_COMMAND")) {
-            fatal_error("Can't write DVDs as sudo because growisofs doesn't support this - see the growisofs manpage for details.");
+            sprintf(command, "strings `which growisofs` | grep -c SUDO_COMMAND");
+            if (!strcmp(call_program_and_get_last_line_of_output(command), "1")) {
+                popup_and_OK("Fatal Error: Can't write DVDs as sudo because growisofs doesn't support this - see the growisofs manpage for details.");
+                fatal_error("Can't write DVDs as sudo because growisofs doesn't support this - see the growisofs manpage for details.");
+            }       
         }
         log_msg(2, "call_make_iso (DVD res) is ... %s",