Changeset 3430 in MondoRescue

Timestamp:

Aug 27, 2015, 10:57:37 AM (9 years ago)

Author:

Bruno Cornec

Message:

• use the keyword TODO (yellow in vim) to indicate code to review instead of BCO|BERLIOS

Location:

branches/3.2

Files:

• mindi/mindi (modified) (3 diffs)
• mindi/rootfs/etc/init.d/rcS (modified) (1 diff)
• mondo/src/common/libmondo-archive.c (modified) (4 diffs)
• mondo/src/common/libmondo-files.c (modified) (3 diffs)
• mondo/src/common/libmondo-mountlist.c (modified) (1 diff)
• mondo/src/common/libmondo-stream.c (modified) (2 diffs)
• mondo/src/mondorestore/mondo-prep.c (modified) (1 diff)
• mondo/src/mondorestore/mondo-rstr-tools.c (modified) (2 diffs)
• mondo/src/mondorestore/mondorestore.c (modified) (2 diffs)

branches/3.2/mindi/mindi

@@ -1781 +1781 @@
     if [ "$CDRECOVERY" = "yes" ] ; then
         if [ "$type" = "grub" ]; then
-            # BCO: Which num ???
+            # TODO: Which num ???
             echo -en "0\n"
         else
@@ -2012 +2012 @@
     mkdir -p $bigdir/tmp
     if [ _"$MONDO_SHARE" != _"" ]; then
-        # BCO: no reason to have the cfg file stored twice
+        # TODO: no reason to have the cfg file stored twice
         MakeMondoConfigFile $MINDI_TMP/$MRCFG
         cp -f $MINDI_TMP/$MRCFG $bigdir/tmp &> /dev/null
@@ -2110 +2110 @@
         fi
         # EFI or UEFI
-        # BCO names are hard-coded for now
+        # TODO: names are hard-coded for now
         if [ "$BOOT_TYPE" = "UEFI" ]; then
             # UEFI

branches/3.2/mindi/rootfs/etc/init.d/rcS

@@ -857 +857 @@
 ExtractDataDisksAndLoadModules() {
     LogIt "Installing additional tools ..." 1
-    # BCO: test return value
+    # TODO: test return value
     install-additional-tools
 

branches/3.2/mondo/src/common/libmondo-archive.c

@@ -502 +502 @@
     char *cd_recovery_sz = NULL;
     char *tape_size_sz = NULL;
-    char *use_lilo_sz = NULL;   /* BCO: shared between LILO/ELILO */
+    char *use_lilo_sz = NULL;   /* TODO: shared between LILO/ELILO */
     char *value = NULL;
     char *bootdev = NULL;
@@ -690 +690 @@
     } else if (bkpinfo->boot_loader == 'E') {
         mr_asprintf(bootldr_str, "ELILO");
-        /* BCO: fix it for Debian, Mageia, ... */
+        /* TODO: fix it for Debian, Mageia, ... */
         if (!does_file_exist("/etc/elilo.conf") && does_file_exist("/boot/efi/efi/redhat/elilo.conf")) {
             run_program_and_log_output("ln -sf /boot/efi/efi/redhat/elilo.conf /etc/elilo.conf", 5);
@@ -891 +891 @@
     log_msg(2, command);
 
-    // BCO old call :
+    // TODO old call :
     //res = run_program_and_log_output(command, FALSE);
     log_msg(1, "Call to mindi");
@@ -2018 +2018 @@
                     log_msg(2, "CHILD - fip - calling feed_into_ntfsprog(%s, %s)", bigfile_fname, sz_devfile);
                     res = feed_into_ntfsprog(bigfile_fname, sz_devfile);
-                    /* BCO/BERLIOS Does the child need to unalocate memory as well ?
+                    /* TODO: Does the child need to unalocate memory as well ?
                     mr_free(bigfile_fname);
                     mr_free(sz_devfile);

branches/3.2/mondo/src/common/libmondo-files.c

@@ -595 +595 @@
             current_time = get_time();
             counter = 0;
-            /* BERLIOS: 37 really ? */
+            /* TODO: 37 really ? */
             curr_fname[37] = '\0';
             curr_pos = ftello(fin) / 1024;
@@ -796 +796 @@
                 }
             } else {
-                /* BERLIOS: more than long here ??? */
+                /* TODO: more than long here ??? */
                 file_len_K = (long) (length_of_file(fname) / 1024);
             }
@@ -1214 +1214 @@
         return (FALSE);
     }
-    /* BERLIOS: This is just plain WRONG !! */
+    /* TODO: This is just plain WRONG !! */
     mr_asprintf(do_not_compress_these,"%s", last_line_of_file(tmp));
     mr_free(tmp);

branches/3.2/mondo/src/common/libmondo-mountlist.c

@@ -565 +565 @@
         }
         log_msg(8,"Entry: %d (%s)", i, drivelist->el[i].device);
-        /* BCO: tmp can be NULL */
+        /* TODO: tmp can be NULL */
         if (tmp != NULL) {
             log_msg(8,"Adding: %s to flaws_str", tmp);

branches/3.2/mondo/src/common/libmondo-stream.c

@@ -1271 +1271 @@
  */
 
-/* BERLIOS: Should be reviewed for mediasize being a off_t ??? */
+/* TODO: Should be reviewed for mediasize being a off_t ??? */
 bool
 should_we_write_to_next_tape(long mediasize,
@@ -1721 +1721 @@
     paranoid_fclose(fin);
     mr_asprintf(checksum, "%04x%04x", crc16, crctt);
-    /* BERLIOS: what does it do ??? */
+    /* TODO: what does it do ??? */
     write_header_block_to_stream((off_t)g_current_media_number, checksum, BLK_STOP_FILE);
     mr_free(checksum);

branches/3.2/mondo/src/mondorestore/mondo-prep.c

@@ -1589 +1589 @@
 mr_asprintf(program, "mr-parted2fdisk %s >> %s 2>> %s", drive, MONDO_LOGFILE, MONDO_LOGFILE);
 
-/* BERLIOS: should not be called each time */
+/* TODO: should not be called each time */
 part_table_fmt = which_partition_format(drive);
 mr_asprintf(output, "");

branches/3.2/mondo/src/mondorestore/mondo-rstr-tools.c

@@ -834 +834 @@
 }
 
-/* BCO: Read here the boot_* variables */
+/* TODO: Read here the boot_* variables */
 read_cfg_var(cfg_file, "boot-type", value);
 if (!strcmp(value, "BIOS")) {
@@ -2010 +2010 @@
         skip_obdr();
     } else {
-        // BCO: below 32KB seems to block at least on RHAS 2.1 and MDK 10.0
+        // TODO: below 32KB seems to block at least on RHAS 2.1 and MDK 10.0
         set_tape_block_size_with_mt(bkpinfo->internal_tape_block_size);
     }

branches/3.2/mondo/src/mondorestore/mondorestore.c

@@ -2704 +2704 @@
         toggle_node_selection(filelist, FALSE);
         toggle_all_root_dirs_on(filelist);
-        // BERLIOS: /usr/lib ???
+        // TODO: /usr/lib ???
         toggle_path_selection(filelist, "/usr/share", TRUE);
         save_filelist(filelist, "/tmp/out.txt");
@@ -2839 +2839 @@
         log_it("Returned from calling load_mountlist and load_raidtab successfully");
 
-        // BCO:To be reviewed
+        // TODO:To be reviewed
         if ((bkpinfo->restore_mode == compare) || (bkpinfo->restore_mode == nuke)) {
             if ((bkpinfo->backup_media_type == netfs) && bkpinfo->netfs_mount && !is_this_device_mounted(bkpinfo->netfs_mount)) {