Changeset 3288 in MondoRescue for branches/3.2/mondo/src/common/libmondo-devices.c

Timestamp:

May 6, 2014, 10:24:12 AM (10 years ago)

Author:

Bruno Cornec

Message:

• Improve again memory management: remove some strcat calls change function percent_media_full_comment to return a dynamically allocated string

File:

• branches/3.2/mondo/src/common/libmondo-devices.c (modified) (3 diffs)

branches/3.2/mondo/src/common/libmondo-devices.c

@@ -1687 +1687 @@
     int c = 0;
     int lastpos = 0;
-    char VG[MAX_STR_LEN];
+    char *VG = NULL;
     char *tmp = NULL;
     char *command = NULL;
@@ -1849 +1849 @@
             mr_asprintf(command, "pvdisplay -v %s 2>/dev/null|grep \"VG Name\"|awk '{print $NF}'", partitions[i]);
             log_msg(5, "  Running: %s", command);
-            strcpy(VG, call_program_and_get_last_line_of_output(command));
+            mr_asprintf(VG, "%s", call_program_and_get_last_line_of_output(command));
             mr_free(command);
 
@@ -1912 +1912 @@
             }
             mr_free(tmp);
+            mr_free(VG);
             continue;
         } else {