Changeset 2928 in MondoRescue

Timestamp:

Dec 23, 2011, 1:09:06 AM (13 years ago)

Author:

Bruno Cornec

Message:

• Fix #500 and #473 by adding support of old metadata format for mdadm if using grub < 0.9x or lilo on a md boot device (to be tested)

File:

• branches/3.0/mondo/src/mondorestore/mondo-prep.c (modified) (4 diffs)

branches/3.0/mondo/src/mondorestore/mondo-prep.c

@@ -10 +10 @@
 #include "mondoprep.h"
 #include "../common/libmondo.h"
+#include "../common/libmondo-tools-EXT.h"
 #include "mondo-rstr-tools-EXT.h"
 #include <sys/ioctl.h>
@@ -44 +45 @@
 
 FILE *g_fprep = NULL;
-
-
+extern char *g_mondo_cfg_file;  // where m*ndo-restore.cfg (the config file) is stored
 
 int g_partition_table_locked_up = 0;
-
-
-
-
-
-
-
 
 
@@ -569 +562 @@
   char *level   = NULL;
   char *program = NULL;
+  char *tmp = NULL;
+  char *oldmd = NULL;
+  char *bootdevice;
+  char *name;
+
+  malloc_string(bootdevice);
+  malloc_string(name);
   
   // leave straight away if raidlist is initial or has no entries
@@ -615 +615 @@
   // - faulty devices ignored
   // - persistent superblock always used as this is recommended
-  mr_asprintf(&program, "mdadm --create --force --run --auto=yes %s --level=%s --raid-devices=%d", raidlist->el[i].raid_device, level, raidlist->el[i].data_disks.entries);
+  // As per bug #473, the parameter "-e 0.90" is used only when:
+  //   1) It detects that system boots from Raid-1
+  //   2) grub bootloader < v1 is used.
+  // Otherwise it won't boot which is bad.
+    read_cfg_var(g_mondo_cfg_file, "bootloader.device", bootdevice);
+    read_cfg_var(g_mondo_cfg_file, "bootloader.name", name);
+    if (strcmp(name,"GRUB") == 0) {
+        mr_asprintf(&tmp, "%s", call_program_and_get_last_line_of_output("grub --version"));
+        if ((strstr(tmp, "GRUB 0.9") != NULL) && (strcmp(raidlist->el[i].raid_device,device) == 0)) {
+            mr_free(oldmd);
+            mr_asprintf(&oldmd, "-e 0.90");
+            log_it("Forcing old metadata 0.90 for md on %s for old GRUB", device);
+        }
+    } else if ((strcmp(name,"LILO") == 0) && (strcmp(raidlist->el[i].raid_device,device) == 0)) {
+        mr_free(oldmd);
+        mr_asprintf(&oldmd, "-e 0.90");
+        log_it("Forcing old metadata 0.90 for md on %s for LILO", device);
+    } else {
+        mr_asprintf(&oldmd, "");
+    }
+    mr_free(device);
+    mr_free(name);
+
+  mr_asprintf(&program, "mdadm --create --force --run --auto=yes %s --level=%s --raid-devices=%d %s", raidlist->el[i].raid_device, level, raidlist->el[i].data_disks.entries, oldmd);
+  mr_free(oldmd);
   if (raidlist->el[i].parity != -1) {
     mr_asprintf(&strtmp, "%s", program);