Changeset 2383 in MondoRescue for branches/2.2.10/mondo/src/common/libmondo-tools.c

Timestamp:

Sep 10, 2009, 2:55:51 AM (15 years ago)

Author:

Bruno Cornec

Message:

call_program_and_get_last_line_of_output is now allocating memory and returning that string

File:

• branches/2.2.10/mondo/src/common/libmondo-tools.c (modified) (11 diffs)

branches/2.2.10/mondo/src/common/libmondo-tools.c

@@ -225 +225 @@
     d = 5.2;                    // :-)
 #else
-    mr_asprintf(tmp, "%s", call_program_and_get_last_line_of_output("uname -r"));
+    tmp = call_program_and_get_last_line_of_output("uname -r");
     p = strchr(tmp, '.');
     if (p) {
@@ -523 +523 @@
         if (getenv ("SUDO_COMMAND")) {
             mr_asprintf(command, "strings `which growisofs` | grep -c SUDO_COMMAND");
-            if (!strcmp(call_program_and_get_last_line_of_output(command), "1")) {
+            tmp = call_program_and_get_last_line_of_output(command);
+            if (!strcmp(tmp, "1")) {
                 mr_free(command);
+                mr_free(tmp);
                 popup_and_OK("Fatal Error: Can't write DVDs as sudo because growisofs doesn't support this - see the growisofs manpage for details.");
                 fatal_error("Can't write DVDs as sudo because growisofs doesn't support this - see the growisofs manpage for details.");
             }       
             mr_free(command);
+            mr_free(tmp);
         }
         log_msg(2, "call_make_iso (DVD res) is ... %s", bkpinfo->call_make_iso);
@@ -613 +616 @@
         mr_asprintf(command, "df -P %s | tail -n1 | cut -d' ' -f1", bkpinfo->isodir);
         log_it("command = %s", command);
-        log_it("res of it = %s", call_program_and_get_last_line_of_output(command));
-        mr_asprintf(iso_dev, "%s", call_program_and_get_last_line_of_output(command));
+        iso_dev = call_program_and_get_last_line_of_output(command);
+        log_it("res of it = %s", iso_dev);
         mr_asprintf(tmp, "%s/ISO-DEV", bkpinfo->tmpdir);
-        write_one_liner_data_file(tmp, call_program_and_get_last_line_of_output(command));
+        write_one_liner_data_file(tmp, iso_dev);
         mr_free(tmp);
         mr_free(command);
@@ -624 +627 @@
 
         log_it("command = %s", command);
-        log_it("res of it = %s", call_program_and_get_last_line_of_output(command));
-        mr_asprintf(iso_mnt, "%s", call_program_and_get_last_line_of_output(command));
+        iso_mnt = call_program_and_get_last_line_of_output(command);
+        log_it("res of it = %s", iso_mnt);
         mr_asprintf(tmp, "%s/ISO-MNT", bkpinfo->tmpdir);
-        write_one_liner_data_file(tmp, call_program_and_get_last_line_of_output(command));
+        write_one_liner_data_file(tmp, iso_mnt);
         mr_free(tmp);
         mr_free(command);
@@ -899 +902 @@
 
     mr_asprintf(command, "df -m -P %s | tail -n1 | tr -s ' ' '\t' | cut -f4", partition);
-    mr_asprintf(out_sz, "%s", call_program_and_get_last_line_of_output(command));
+    out_sz = call_program_and_get_last_line_of_output(command);
     mr_free(command);
 
@@ -941 +944 @@
         run_program_and_log_output("ln -sf `which mkfs.msdos` /sbin/mkfs.vfat", FALSE);
     }
-    mr_asprintf(tmp, "%s", call_program_and_get_last_line_of_output("free | grep Mem | head -n1 | tr -s ' ' '\t' | cut -f2"));
+    tmp = call_program_and_get_last_line_of_output("free | grep Mem | head -n1 | tr -s ' ' '\t' | cut -f2");
     if (atol(tmp) < 35000) {
         retval++;
@@ -1014 +1017 @@
 
     run_program_and_log_output("umount `mount | grep cdr | cut -d' ' -f3 | tr '\n' ' '`", 5);
-    mr_asprintf(tmp, "%s", call_program_and_get_last_line_of_output("mount | grep -E \"cdr(om|w)\""));
+    tmp = call_program_and_get_last_line_of_output("mount | grep -E \"cdr(om|w)\"");
     if (strcmp("", tmp)) {
         if (strstr(tmp, "autofs")) {
@@ -1104 +1107 @@
     } else {
         mr_asprintf(command, "grep '%s .*' %s| cut -d' ' -f2,3,4,5", label, config_file);
-        mr_asprintf(value, "%s", call_program_and_get_last_line_of_output(command));
+        value = call_program_and_get_last_line_of_output(command);
         mr_free(command);
 
@@ -1232 +1235 @@
     mr_asprintf(command, "%s", "grep -v \":\" /etc/fstab | grep -vE '^#.*$' | grep -E \"[   ]/boot[     ]\" | tr -s ' ' '\t' | cut -f1 | head -n1");
     log_msg(4, "Cool. Command = '%s'", command);
-    mr_asprintf(tmp, "%s", call_program_and_get_last_line_of_output(command));
+    tmp = call_program_and_get_last_line_of_output(command);
     mr_free(command);
 
@@ -1239 +1242 @@
     mr_asprintf(command, "mount | grep -Ew '/boot'");
     mr_free(tmp);
-    mr_asprintf(tmp, "%s", call_program_and_get_last_line_of_output(command));
+    tmp = call_program_and_get_last_line_of_output(command);
     mr_free(command);
 
@@ -1439 +1442 @@
  * The command used to start it is saved in @p g_magicdev_command.
  */
-void stop_magicdev_if_necessary()
-{
-    strcpy(g_magicdev_command,
-           call_program_and_get_last_line_of_output
-           ("ps ax | grep -w magicdev | grep -v grep | tr -s '\t' ' '| cut -d' ' -f6-99"));
+void stop_magicdev_if_necessary() {
+
+    char *tmp = NULL;
+
+    tmp = call_program_and_get_last_line_of_output("ps ax | grep -w magicdev | grep -v grep | tr -s '\t' ' '| cut -d' ' -f6-99");
+
+    strcpy(g_magicdev_command, tmp);
+    mr_free(tmp);
+
     if (g_magicdev_command[0]) {
         log_msg(1, "g_magicdev_command = '%s'", g_magicdev_command);