Ignore:
Timestamp:
Jul 23, 2009, 2:53:30 PM (15 years ago)
Author:
Bruno Cornec
Message:
  • Replace sprintf by mr_asprintf in mondo-rstr-compare.c
  • All mr_asprintf call should be on one line (for quality script) and use a string as second param
  • Improve quality script
File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/2.2.10/mondo/src/mondorestore/mondorestore.c

    r2291 r2296  
    668668            strcpy(fstab_fname, "/tmp/fstab");
    669669        }
    670         mr_asprintf(&tmp1,
    671                 "label-partitions-as-necessary %s < %s >> %s 2>> %s",
    672                 g_mountlist_fname, fstab_fname, MONDO_LOGFILE,
    673                 MONDO_LOGFILE);
     670        mr_asprintf(&tmp1, "label-partitions-as-necessary %s < %s >> %s 2>> %s", g_mountlist_fname, fstab_fname, MONDO_LOGFILE, MONDO_LOGFILE);
    674671        res = system(tmp1);
    675672        mr_free(tmp1);
     
    811808    }
    812809    if (!evaluate_mountlist(mountlist, tmpA, tmpB, tmpC)) {
    813         mr_asprintf(&tmp,
    814                 "Mountlist analyzed. Result: \"%s %s %s\" Switch to Interactive Mode?",
    815                 tmpA, tmpB, tmpC);
     810        mr_asprintf(&tmp, "Mountlist analyzed. Result: \"%s %s %s\" Switch to Interactive Mode?", tmpA, tmpB, tmpC);
    816811        res = ask_me_yes_or_no(tmp);
    817812        mr_free(tmp);
     
    12931288            }
    12941289            mds = media_descriptor_string(bkpinfo->backup_media_type);
    1295             mr_asprintf(&tmp, "Working on %s #%d, file #%ld, slice #%ld    ", mds,
    1296                     g_current_media_number, bigfileno + 1, sliceno);
     1290            mr_asprintf(&tmp, "Working on %s #%d, file #%ld, slice #%ld    ", mds, g_current_media_number, bigfileno + 1, sliceno);
    12971291            mr_free(mds);
    12981292            log_msg(2, tmp);
     
    13291323    if (use_ntfsprog_hack) {
    13301324        log_msg(3, "Waiting for ntfsclone to finish");
    1331         mr_asprintf(&tmp,
    1332                 " ps | grep \" ntfsclone \" | grep -v grep > /dev/null 2> /dev/null");
     1325        mr_asprintf(&tmp, " ps | grep \" ntfsclone \" | grep -v grep > /dev/null 2> /dev/null");
    13331326        while (system(tmp) == 0) {
    13341327            sleep(1);
     
    14641457        use_ntfsprog_hack = TRUE;
    14651458        log_msg(2, "Calling ntfsclone in background because %s is a /dev entry", outfile_fname);
    1466         mr_asprintf(&sz_devfile, "%s/%d.%d.000",
    1467                 bkpinfo->tmpdir,
    1468                 (int) (random() % 32768),
    1469                 (int) (random() % 32768));
     1459        mr_asprintf(&sz_devfile, "%s/%d.%d.000", bkpinfo->tmpdir, (int) (random() % 32768), (int) (random() % 32768));
    14701460        mkfifo(sz_devfile, 0x770);
    14711461        strcpy(ntfsprog_fifo, sz_devfile);
     
    16841674            log_msg(3, "Saved fileset %ld's subset to %s", current_tarball_number, filelist_subset_fname);
    16851675        }
    1686         mr_asprintf(&screen_message, "Tarball #%ld --- %ld matches",
    1687                 current_tarball_number, matches);
     1676        mr_asprintf(&screen_message, "Tarball #%ld --- %ld matches", current_tarball_number, matches);
    16881677        log_to_screen(screen_message);
    16891678        mr_free(screen_message);
     
    22372226            }
    22382227            g_current_media_number++;
    2239             mr_asprintf(&progress_str, "Restoring from %s #%d",
    2240                     media_descriptor_string(bkpinfo->backup_media_type),
    2241                     g_current_media_number);
     2228            mr_asprintf(&progress_str, "Restoring from %s #%d", media_descriptor_string(bkpinfo->backup_media_type), g_current_media_number);
    22422229            log_to_screen(progress_str);
    22432230        } else {
    2244             mr_asprintf(&progress_str, "Restoring from fileset #%ld on %s #%d",
    2245                     current_tarball_number, mds, g_current_media_number);
     2231            mr_asprintf(&progress_str, "Restoring from fileset #%ld on %s #%d", current_tarball_number, mds, g_current_media_number);
    22462232            for (res = 999, attempts = 0; attempts < 3 && res != 0;
    22472233                 attempts++) {
     
    22512237                                              filelist);
    22522238            }
    2253             mr_asprintf(&tmp1, "%s #%d, fileset #%ld - restore ",
    2254                     mds, g_current_media_number, current_tarball_number);
     2239            mr_asprintf(&tmp1, "%s #%d, fileset #%ld - restore ", mds, g_current_media_number, current_tarball_number);
    22552240            if (res) {
    22562241                mr_strcat(tmp1, "reported errors");
     
    23812366            p++;
    23822367        }
    2383         mr_asprintf(&tmp1, "Restoring big file %ld (%lld K)",
    2384                 current_bigfile_number + 1, biggie_size / 1024);
     2368        mr_asprintf(&tmp1, "Restoring big file %ld (%lld K)", current_bigfile_number + 1, biggie_size / 1024);
    23852369        update_progress_form(tmp1);
    23862370        mr_free(tmp1);
     
    25192503        update_progress_form(progress_str);
    25202504        if (g_getfattr) {
    2521             mr_asprintf(&xattr_fname, "%s/xattr-subset-%ld.tmp", bkpinfo->tmpdir,
    2522                 current_afioball_number);
     2505            mr_asprintf(&xattr_fname, "%s/xattr-subset-%ld.tmp", bkpinfo->tmpdir, current_afioball_number);
    25232506            unlink(xattr_fname);
    25242507        }
Note: See TracChangeset for help on using the changeset viewer.