Changeset 2214 in MondoRescue for branches/2.2.9/mondo/src/common/libmondo-fifo.c

Timestamp:

Jun 3, 2009, 7:10:28 PM (15 years ago)

Author:

Bruno Cornec

Message:

r3094@localhost: bruno | 2009-06-03 17:25:25 +0200

Replaces strcpy in 5 source where no other impact by mr_asprintf. Improves quality report

File:

• branches/2.2.9/mondo/src/common/libmondo-fifo.c (modified) (2 diffs)

branches/2.2.9/mondo/src/common/libmondo-fifo.c

@@ -155 +155 @@
 void kill_buffer()
 {
-    char *tmp;
-    char *command;
+    char *tmp = NULL;
+    char *command = NULL;
 
     if (g_sz_call_to_buffer == NULL) {
@@ -164 +164 @@
         return;
     }
-    malloc_string(tmp);
-    malloc_string(command);
     paranoid_system("sync");
-    sprintf(command,
+    mr_asprintf(&command,
             "ps %s | grep -F \"%s\" | grep -Fv grep | awk '{print $2;}' | grep -v PID | head -1", ps_options, g_sz_call_to_buffer);
     log_msg(2, "kill_buffer() --- command = %s", command);
-    strcpy(tmp, call_program_and_get_last_line_of_output(command));
-    sprintf(command, "kill %s", tmp);
+    mr_asprintf(&tmp, call_program_and_get_last_line_of_output(command));
+    mr_free(command);
+
+    mr_asprintf(&command, "kill %s", tmp);
     log_msg(2, "kill_buffer() --- command = %s", command);
     if (strlen(tmp) > 0) {
         run_program_and_log_output(command, TRUE);
     }
-    paranoid_free(tmp);
-    paranoid_free(command);
+    mr_free(tmp);
+    mr_free(command);
 }