Changeset 1770 in MondoRescue for branches/stable/mindi-busybox/networking/udhcp/dhcpd.c

Timestamp:

Nov 6, 2007, 11:01:53 AM (16 years ago)

Author:

Bruno Cornec

Message:

• Better output for mindi-busybox revision
• Remove dummy file created on NFS - report from Arnaud Tiger <arnaud.tiger_at_hp.com>
• strace useful for debug
• fix new versions for pb (2.0.0 for mindi and 1.7.2 for mindi-busybox)
• fix build process for mindi-busybox + options used in that version (dd for label-partitions-as-necessary)
• fix typo in label-partitions-as-necessary which doesn't seem to work
• Update to busybox 1.7.2
• perl is now required at restore time to support uuid swap partitions (and will be used for many other thigs

in the future for sure)

• next mindi version will be 2.0.0 due to all the changes made in it (udev may break working distros)
• small optimization in mindi on keyboard handling (one single find instead of multiple)
• better interaction for USB device when launching mindi manually
• attempt to automatically guess block disk size for ramdisk
• fix typos in bkphw
• Fix the remaining problem with UUID support for swap partitions
• Updates mondoarchive man page for USB support
• Adds preliminary Hardware support to mindi (Proliant SSSTK)
• Tries to add udev support also for rhel4
• Fix UUID support which was still broken.
• Be conservative in test for the start-nfs script
• Update config file for mindi-busybox for 1.7.2 migration
• Try to run around a busybox bug (1.2.2 pb on inexistant links)
• Add build content for mindi-busybox in pb
• Remove distributions content for mindi-busybox
• Fix a warning on inexistant raidtab
• Solve problem on tmpfs in restore init (Problem of inexistant symlink and busybox)
• Create MONDO_CACHE and use it everywhere + creation at start
• Really never try to eject a USB device
• Fix a issue with &> usage (replaced with 1> and 2>)
• Adds magic file to depllist in order to have file working + ldd which helps for debugging issues
• tty modes correct to avoid sh error messages
• Use ext3 normally and not ext2 instead
• USB device should be corrected after reading (take 1st part)
• Adds a mount_USB_here function derived from mount_CDROM_here
• usb detection place before /dev detection in device name at restore time
• Fix when restoring from USB: media is asked in interactive mode
• Adds USB support for mondorestore
• mount_cdrom => mount_media
• elilo.efi is now searched throughout /boot/efi and not in a fixed place as there is no standard
• untar-and-softlink => untar (+ interface change)
• suppress useless softlinks creation/removal in boot process
• avoids udevd messages on groups
• Increase # of disks to 99 as in mindi at restore time (should be a conf file parameter)
• skip existing big file creation
• seems to work correctly for USB mindi boot
• Adds group and tty link to udev conf
• Always load usb-torage (even 2.6) to initiate USB bus discovery
• Better printing of messages
• Attempt to fix a bug in supporting OpenSusE 10.3 kernel for initramfs (mindi may now use multiple regex for kernel initrd detection)
• Links were not correctly done as non relative for modules in mindi
• exclusion of modules denied now works
• Also create modules in their ordinary place, so that classical modprobe works + copy modules.dep
• Fix bugs for DENY_MODS handling
• Add device /dev/console for udev
• ide-generic should now really be excluded
• Fix a bug in major number for tty
• If udev then adds modprobe/insmod to rootfs
• tty0 is also cretaed with udev
• ide-generic put rather in DENY_MODS
• udevd remove from deplist s handled in mindi directly
• better default for mindi when using --usb
• Handles dynamically linked busybox (in case we want to use it soon ;-)
• Adds fixed devices to create for udev
• ide-generic should not be part of the initrd when using libata v2
• support a dynamically linked udev (case on Ubuntu 7.10 and Mandriva 2008.0 so should be quite generic) This will give incitation to move to dyn. linked binaries in the initrd which will help for other tasks (ia6 4)
• Improvement in udev support (do not use cl options not available in busybox)
• Udev in mindi
  • auto creation of the right links at boot time with udev-links.conf(from Mandriva 2008.0)
  • rework startup of udev as current makes kernel crash (from Mandriva 2008.0)
  • add support for 64 bits udev
• Try to render MyInsmod silent at boot time
• Adds udev support (mandatory for newest distributions to avoid remapping of devices in a different way as on the original system)
• We also need vaft format support for USB boot
• Adds libusual support (Ubuntu 7.10 needs it for USB)
• Improve Ubuntu/Debian keyboard detection and support
• pbinit adapted to new pb (0.8.10). Filtering of docs done in it
• Suppress some mondo warnings and errors on USB again
• Tries to fix lack of files in deb mindi package
• Verify should now work for USB devices
• More log/mesages improvement for USB support
• - Supress g_erase_tmpdir_and_scratchdir
• Improve some log messages for USB support
• Try to improve install in mindi to avoid issues with isolinux.cfg not installed vene if in the pkg :-(
• Improve mindi-busybox build
• In conformity with pb 0.8.9
• Add support for Ubuntu 7.10 in build process
• Add USB Key button to Menu UI (CD streamer removed)
• Attempt to fix error messages on tmp/scratch files at the end by removing those dir at the latest possible.
• Fix a bug linked to the size of the -E param which could be used (Arnaud Tiger/René Ribaud).
• Integrate ~/.pbrc content into mondorescue.pb (required project-builder >= 0.8.7)
• Put mondorescue in conformity with new pb filtering rules
• Add USB support at restore time (no test done yet). New start-usb script PB varibale added where useful
• Unmounting USB device before removal of temporary scratchdir
• Stil refining USB copy back to mondo (one command was not executed)
• No need to have the image subdor in the csratchdir when USB.
• umount the USB partition before attempting to use it
• Remove useless copy from mindi to mondo at end of USB handling

(risky merge, we are raising the limits of 2 diverging branches. The status of stable is not completely sure as such. Will need lots of tests, but it's not yet done :-()
(merge -r1692:1769 $SVN_M/branches/2.2.5)

File:

• branches/stable/mindi-busybox/networking/udhcp/dhcpd.c (modified) (11 diffs)

branches/stable/mindi-busybox/networking/udhcp/dhcpd.c

@@ +1 @@
+/* vi: set sw=4 ts=4: */
 /* dhcpd.c
  *
@@ -10 +11 @@
  */
 
-#include <fcntl.h>
-#include <string.h>
-#include <stdlib.h>
-#include <sys/wait.h>
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
-#include <sys/socket.h>
-#include <unistd.h>
-#include <signal.h>
-#include <errno.h>
-#include <sys/ioctl.h>
-#include <time.h>
-
+#include <syslog.h>
+#include "common.h"
 #include "dhcpd.h"
-#include "arpping.h"
-#include "socket.h"
 #include "options.h"
-#include "files.h"
-#include "serverpacket.h"
-#include "common.h"
-#include "signalpipe.h"
-#include "static_leases.h"
 
 
@@ -40 +22 @@
 
 
-int udhcpd_main(int argc, char *argv[])
+int udhcpd_main(int argc, char **argv);
+int udhcpd_main(int argc, char **argv)
 {
     fd_set rfds;
@@ -48 +31 @@
     uint8_t *state, *server_id, *requested;
     uint32_t server_id_align, requested_align, static_lease_ip;
-    unsigned long timeout_end, num_ips;
+    unsigned timeout_end;
+    unsigned num_ips;
+    unsigned opt;
     struct option_set *option;
     struct dhcpOfferedAddr *lease, static_lease;
 
-    read_config(argc < 2 ? DHCPD_CONF_FILE : argv[1]);
-
-    /* Start the log, sanitize fd's, and write a pid file */
-    udhcp_start_log_and_pid("udhcpd", server_config.pidfile);
-
-    if ((option = find_option(server_config.options, DHCP_LEASE_TIME))) {
+    opt = getopt32(argv, "fS");
+    argv += optind;
+
+    if (!(opt & 1)) { /* no -f */
+        bb_daemonize_or_rexec(0, argv);
+        logmode &= ~LOGMODE_STDIO;
+    }
+
+    if (opt & 2) { /* -S */
+        openlog(applet_name, LOG_PID, LOG_LOCAL0);
+        logmode |= LOGMODE_SYSLOG;
+    }
+
+    /* Would rather not do read_config before daemonization -
+     * otherwise NOMMU machines will parse config twice */
+    read_config(argv[0] ? argv[0] : DHCPD_CONF_FILE);
+
+    /* Make sure fd 0,1,2 are open */
+    bb_sanitize_stdio();
+    /* Equivalent of doing a fflush after every \n */
+    setlinebuf(stdout);
+
+    /* Create pidfile */
+    write_pidfile(server_config.pidfile);
+    /* if (!..) bb_perror_msg("cannot create pidfile %s", pidfile); */
+
+    bb_info_msg("%s (v%s) started", applet_name, BB_VER);
+
+    option = find_option(server_config.options, DHCP_LEASE_TIME);
+    server_config.lease = LEASE_TIME;
+    if (option) {
         memcpy(&server_config.lease, option->data + 2, 4);
         server_config.lease = ntohl(server_config.lease);
     }
-    else server_config.lease = LEASE_TIME;
 
     /* Sanity check */
-    num_ips = ntohl(server_config.end) - ntohl(server_config.start) + 1;
+    num_ips = server_config.end_ip - server_config.start_ip + 1;
     if (server_config.max_leases > num_ips) {
-        LOG(LOG_ERR, "max_leases value (%lu) not sane, "
-            "setting to %lu instead",
-            server_config.max_leases, num_ips);
+        bb_error_msg("max_leases=%u is too big, setting to %u",
+            (unsigned)server_config.max_leases, num_ips);
         server_config.max_leases = num_ips;
     }
 
-    leases = xzalloc(server_config.max_leases * sizeof(struct dhcpOfferedAddr));
+    leases = xzalloc(server_config.max_leases * sizeof(*leases));
     read_leases(server_config.lease_file);
 
     if (read_interface(server_config.interface, &server_config.ifindex,
-               &server_config.server, server_config.arp) < 0)
-        return 1;
-
-    if (!ENABLE_FEATURE_UDHCP_DEBUG)
-        udhcp_background(server_config.pidfile); /* hold lock during fork. */
+               &server_config.server, server_config.arp)) {
+        retval = 1;
+        goto ret;
+    }
 
     /* Setup the signal pipe */
     udhcp_sp_setup();
 
-    timeout_end = time(0) + server_config.auto_time;
-    while(1) { /* loop until universe collapses */
-
-        if (server_socket < 0)
-            if ((server_socket = listen_socket(INADDR_ANY, SERVER_PORT, server_config.interface)) < 0) {
-                LOG(LOG_ERR, "FATAL: couldn't create server socket, %m");
-                return 2;
-            }
+    timeout_end = monotonic_sec() + server_config.auto_time;
+    while (1) { /* loop until universe collapses */
+
+        if (server_socket < 0) {
+            server_socket = listen_socket(/*INADDR_ANY,*/ SERVER_PORT,
+                    server_config.interface);
+        }
 
         max_sock = udhcp_sp_fd_set(&rfds, server_socket);
         if (server_config.auto_time) {
-            tv.tv_sec = timeout_end - time(0);
+            tv.tv_sec = timeout_end - monotonic_sec();
             tv.tv_usec = 0;
         }
+        retval = 0;
         if (!server_config.auto_time || tv.tv_sec > 0) {
             retval = select(max_sock + 1, &rfds, NULL, NULL,
                     server_config.auto_time ? &tv : NULL);
-        } else retval = 0; /* If we already timed out, fall through */
-
+        }
         if (retval == 0) {
             write_leases();
-            timeout_end = time(0) + server_config.auto_time;
-            continue;
-        } else if (retval < 0 && errno != EINTR) {
-            DEBUG(LOG_INFO, "error on select");
+            timeout_end = monotonic_sec() + server_config.auto_time;
+            continue;
+        }
+        if (retval < 0 && errno != EINTR) {
+            DEBUG("error on select");
             continue;
         }
@@ -115 +122 @@
         switch (udhcp_sp_read(&rfds)) {
         case SIGUSR1:
-            LOG(LOG_INFO, "Received a SIGUSR1");
+            bb_info_msg("Received a SIGUSR1");
             write_leases();
             /* why not just reset the timeout, eh */
-            timeout_end = time(0) + server_config.auto_time;
+            timeout_end = monotonic_sec() + server_config.auto_time;
             continue;
         case SIGTERM:
-            LOG(LOG_INFO, "Received a SIGTERM");
-            return 0;
+            bb_info_msg("Received a SIGTERM");
+            goto ret0;
         case 0: break;      /* no signal */
         default: continue;  /* signal or error (probably EINTR) */
         }
 
-        if ((bytes = udhcp_get_packet(&packet, server_socket)) < 0) { /* this waits for a packet - idle */
+        bytes = udhcp_get_packet(&packet, server_socket); /* this waits for a packet - idle */
+        if (bytes < 0) {
             if (bytes == -1 && errno != EINTR) {
-                DEBUG(LOG_INFO, "error on read, %m, reopening socket");
+                DEBUG("error on read, %s, reopening socket", strerror(errno));
                 close(server_socket);
                 server_socket = -1;
@@ -136 +144 @@
         }
 
-        if ((state = get_option(&packet, DHCP_MESSAGE_TYPE)) == NULL) {
-            DEBUG(LOG_ERR, "couldn't get option from packet, ignoring");
+        state = get_option(&packet, DHCP_MESSAGE_TYPE);
+        if (state == NULL) {
+            bb_error_msg("cannot get option from packet, ignoring");
             continue;
         }
@@ -144 +153 @@
         static_lease_ip = getIpByMac(server_config.static_leases, &packet.chaddr);
 
-        if(static_lease_ip)
-        {
-            printf("Found static lease: %x\n", static_lease_ip);
+        if (static_lease_ip) {
+            bb_info_msg("Found static lease: %x", static_lease_ip);
 
             memcpy(&static_lease.chaddr, &packet.chaddr, 16);
@@ -153 +161 @@
 
             lease = &static_lease;
-
-        }
-        else
-        {
-        lease = find_lease_by_chaddr(packet.chaddr);
+        } else {
+            lease = find_lease_by_chaddr(packet.chaddr);
         }
 
         switch (state[0]) {
         case DHCPDISCOVER:
-            DEBUG(LOG_INFO,"received DISCOVER");
+            DEBUG("Received DISCOVER");
 
             if (sendOffer(&packet) < 0) {
-                LOG(LOG_ERR, "send OFFER failed");
+                bb_error_msg("send OFFER failed");
             }
             break;
         case DHCPREQUEST:
-            DEBUG(LOG_INFO, "received REQUEST");
+            DEBUG("received REQUEST");
 
             requested = get_option(&packet, DHCP_REQUESTED_IP);
@@ -180 +185 @@
                 if (server_id) {
                     /* SELECTING State */
-                    DEBUG(LOG_INFO, "server_id = %08x", ntohl(server_id_align));
-                    if (server_id_align == server_config.server && requested &&
-                        requested_align == lease->yiaddr) {
+                    DEBUG("server_id = %08x", ntohl(server_id_align));
+                    if (server_id_align == server_config.server && requested
+                     && requested_align == lease->yiaddr
+                    ) {
                         sendACK(&packet, lease->yiaddr);
                     }
+                } else if (requested) {
+                    /* INIT-REBOOT State */
+                    if (lease->yiaddr == requested_align)
+                        sendACK(&packet, lease->yiaddr);
+                    else
+                        sendNAK(&packet);
+                } else if (lease->yiaddr == packet.ciaddr) {
+                    /* RENEWING or REBINDING State */
+                    sendACK(&packet, lease->yiaddr);
                 } else {
-                    if (requested) {
-                        /* INIT-REBOOT State */
-                        if (lease->yiaddr == requested_align)
-                            sendACK(&packet, lease->yiaddr);
-                        else sendNAK(&packet);
-                    } else {
-                        /* RENEWING or REBINDING State */
-                        if (lease->yiaddr == packet.ciaddr)
-                            sendACK(&packet, lease->yiaddr);
-                        else {
-                            /* don't know what to do!!!! */
-                            sendNAK(&packet);
-                        }
-                    }
+                    /* don't know what to do!!!! */
+                    sendNAK(&packet);
                 }
 
@@ -208 +211 @@
             } else if (requested) {
                 /* INIT-REBOOT State */
-                if ((lease = find_lease_by_yiaddr(requested_align))) {
+                lease = find_lease_by_yiaddr(requested_align);
+                if (lease) {
                     if (lease_expired(lease)) {
                         /* probably best if we drop this lease */
                         memset(lease->chaddr, 0, 16);
                     /* make some contention for this address */
-                    } else sendNAK(&packet);
-                } else if (requested_align < server_config.start ||
-                       requested_align > server_config.end) {
-                    sendNAK(&packet);
-                } /* else remain silent */
+                    } else
+                        sendNAK(&packet);
+                } else {
+                    uint32_t r = ntohl(requested_align);
+                    if (r < server_config.start_ip
+                         || r > server_config.end_ip
+                    ) {
+                        sendNAK(&packet);
+                    }
+                    /* else remain silent */
+                }
 
             } else {
-                 /* RENEWING or REBINDING State */
+                /* RENEWING or REBINDING State */
             }
             break;
         case DHCPDECLINE:
-            DEBUG(LOG_INFO,"received DECLINE");
+            DEBUG("Received DECLINE");
             if (lease) {
                 memset(lease->chaddr, 0, 16);
@@ -231 +241 @@
             break;
         case DHCPRELEASE:
-            DEBUG(LOG_INFO,"received RELEASE");
-            if (lease) lease->expires = time(0);
+            DEBUG("Received RELEASE");
+            if (lease)
+                lease->expires = time(0);
             break;
         case DHCPINFORM:
-            DEBUG(LOG_INFO,"received INFORM");
+            DEBUG("Received INFORM");
             send_inform(&packet);
             break;
         default:
-            LOG(LOG_WARNING, "unsupported DHCP message (%02x) -- ignoring", state[0]);
-        }
-    }
-
-    return 0;
+            bb_info_msg("Unsupported DHCP message (%02x) - ignoring", state[0]);
+        }
+    }
+ ret0:
+    retval = 0;
+ ret:
+    /*if (server_config.pidfile) - server_config.pidfile is never NULL */
+        remove_pidfile(server_config.pidfile);
+    return retval;
 }
-