Changeset 273 in MondoRescue for branches/2.06/mondo/mondo/common/X-specific.cpp

Timestamp:

Jan 3, 2006, 4:09:12 PM (18 years ago)

Author:

bcornec

Message:

Patches from Sébastien Aperghis-Tramoni <maddingue@…>

replace several occurences of "cat .. | grep .."
or with similar commands that accept filenames as arguments.
+ some sort | uniq replaced by sort -u

File:

• branches/2.06/mondo/mondo/common/X-specific.cpp (modified) (2 diffs)

branches/2.06/mondo/mondo/common/X-specific.cpp

@@ -197 +197 @@
     kapp->quit();
     printf ("---FATAL ERROR--- %s\n", error);
-    system ("cat /var/log/mondo-archive.log | gzip -9 > /tmp/MA.log.gz 2> /dev/null");
+    system ("gzip -9c /var/log/mondo-archive.log > /tmp/MA.log.gz 2> /dev/null");
     printf ("If you require technical support, please contact the mailing list.\n");
     printf ("See http://www.mondorescue.org for details.\n");
@@ -252 +252 @@
   if (grep_for_me[0] != '\0')
     {
-      sprintf (command, "cat %s | grep \"%s\" | tail -n%d", filename,
-           grep_for_me, NOOF_ERR_LINES);
+      sprintf (command, "grep \"%s\" %s | tail -n%d", 
+           grep_for_me, filename, NOOF_ERR_LINES);
     }
   else
     {
-      sprintf (command, "cat %s | tail -n%d", filename, NOOF_ERR_LINES);
+      sprintf (command, "tail -n%d %s", NOOF_ERR_LINES, filename);
     }
   fin = popen (command, "r");