Changeset 2202 in MondoRescue for branches/2.2.9/mondo/src/common/libmondo-cli.c

Timestamp:

May 13, 2009, 4:34:00 AM (15 years ago)

Author:

Bruno Cornec

Message:

• Remove useless function look_for_weird_formats
• Adds a test program for mountlist management to find a seg. fault bug when using a large mountlist file

File:

• branches/2.2.9/mondo/src/common/libmondo-cli.c (modified) (4 diffs)

branches/2.2.9/mondo/src/common/libmondo-cli.c

@@ -1444 +1444 @@
     /*@ ints ** */
     int opt = 0;
-    char tmp[MAX_STR_LEN];
+    char *tmp = NULL;
     int i = 0;
     int len;
@@ -1467 +1467 @@
             if (flag_set[optopt]) {
                 bad_switches = TRUE;
-                sprintf(tmp, "Switch -%c previously defined as %s\n", opt,
+                (void) asprintf(&tmp, "Switch -%c previously defined as %s\n", opt,
                         flag_val[i]);
                 log_to_screen(tmp);
+                paranoid_free(tmp);
             } else {
                 flag_set[opt] = TRUE;
@@ -1483 +1484 @@
                         if (strchr(flag_val[opt], '/')
                             && flag_val[opt][0] != '/') {
-                            sprintf(tmp,
+                            (void)asprintf(&tmp,
                                     "-%c flag --- must be absolute path --- '%s' isn't absolute",
                                     opt, flag_val[opt]);
                             log_to_screen(tmp);
+                            paranoid_free(tmp);
                             bad_switches = TRUE;
                         }
@@ -1497 +1499 @@
     for (i = optind; i < argc; i++) {
         bad_switches = TRUE;
-        sprintf(tmp, "Invalid arg -- %s\n", argv[i]);
+        (void)asprintf(&tmp, "Invalid arg -- %s\n", argv[i]);
         log_to_screen(tmp);
+        paranoid_free(tmp);
     }
     return (bad_switches);