Changeset 2150 in MondoRescue

Timestamp:

Feb 16, 2009, 6:32:32 PM (15 years ago)

Author:

Bruno Cornec

Message:

• Fix a nasty bug where if /tmp was full, mktemp is returning empty, and thus we were doing all type of bad things :-(

mktemp return is now checked before usage (as it should !)
Thnaks should go to Jean-Marc Andre (jean-marc.andre_at_hp.com) who suffered from the bug (unusable machine after backup :-() and who was willing to find what happened and finally produced the log files which permitted that analysis.

File:

• branches/2.2.9/mindi/mindi (modified) (2 diffs)

branches/2.2.9/mindi/mindi

@@ -93 +93 @@
 
 # Now we can create what we need
-export MINDI_TMP=`mktemp -d $TMPDIR/mindi.XXXXXXXXXX`
+MINDI_TMP=`mktemp -d $TMPDIR/mindi.XXXXXXXXXX`
+if [ $? -ne 0 ]; then
+    df $TMPDIR
+    Die "Unable to create a temporary directory ! Check space on $TMPDIR"
+fi
+export MINDI_TMP
 
 # ----------------------------------------------------------------------------
@@ -233 +238 @@
     # Clean temporary files only when standalone mindi
     if [ _"$MINDI_TMP" != _"$MONDO_TMP" ]; then
-        rm -Rf $MINDI_TMP
+        # If no space on /tmp we may have an empty var
+        if [ _"$MINDI_TMP" != _"" ]; then
+            # Paranoid mode
+            if [ _"$MINDI_TMP" != _"/" ]; then
+                rm -Rf $MINDI_TMP
+            fi
+        fi
     fi
     exit $1