Changeset 126 in MondoRescue for branches/2.05/mondo/mondo/common/libmondo-files.c

Timestamp:

Nov 19, 2005, 1:53:52 AM (18 years ago)

Author:

bcornec

Message:

This patch avoids useless invocations of `cat <file> |' where the second
process in the pipe can more efficiently read its input file itself.
It replaces also some grep'+sed' commands by an unique `sed' command.
This patch also improves readability of shell commands by
replacing \" by ' where possible.
This patch instructs mondo to say DVD' instead of CD' when appropriate.
This patch forces growisofs to use speed=1 for DVD burning. In my
experience, DVD burning time is only a small part of the total backup
time so this should not make a big difference in backup time, but
a big one in reliability of mondo. On my installation, without
the option `speed=1', mondo/growisofs is unable to burn a DVD. With
the option `speed=1', mondo works.
(Philippe De Muyter)

File:

• branches/2.05/mondo/mondo/common/libmondo-files.c (modified) (2 diffs)

branches/2.05/mondo/mondo/common/libmondo-files.c

@@ -569 +569 @@
         return (output);
     }
-    sprintf(command, "cat %s | tail -n1", filename);
+    sprintf(command, "tail -n1 %s", filename);
     fin = popen(command, "r");
     (void) fgets(output, MAX_STR_LEN, fin);
@@ -1309 +1309 @@
     if (scratchLL <= 1) {
         sprintf(tmp,
-                "Your backup will probably occupy a single CD/tape/ISO. Maybe two.");
+                "Your backup will probably occupy a single %s. Maybe two.",
+                media_descriptor_string(bkpinfo->backup_media_type));
     } else if (scratchLL > 4) {
         sprintf(tmp,